Page MenuHomeFreeBSD

[new port] sysutils/apache-mesos: Apache Mesos cluster management software
Needs ReviewPublic

Authored by james.wright_digital-chaos.com on May 12 2019, 11:31 PM.

Details

Reviewers
tobik
Group Reviewers
Contributor Reviewers (ports)
Summary

New port for the Apache Mesos cluster management software.

This is an initial version to gain some feedback on how the port looks thus far, and currently does not include options to enable Java or Python bindings for simplicity.

Bugzilla
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237859

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

This needs to be hooked into sysutils/Makefile

linimon retitled this revision from sysutils/apache-mesos: New port to [new port] sysutils/apache-mesos: Apache Mesos cluster management software.May 13 2019, 4:37 PM

Added SUBDIR += apache-mesos to sysutils/Makefile, as requested.

tobik requested changes to this revision.May 14 2019, 7:41 AM
tobik added a subscriber: tobik.
tobik added inline comments.
sysutils/apache-mesos/Makefile
7

Use curly braces {} here.

11

"Apache Foundation open-source project" seems like filler and does not say much about Mesos.

31
  • Since you are installing shared libraries you must have USE_LDCONFIG=yes.
  • We do not install *.la files unless there is a good reason to have them such as needing lt_dlopen() and libltdl at runtime. AFAICT this is not the case here, so please add USES=libtool as pointed out by stage-qa
  • The port seems to install Python scripts even with --disable-python but does not declare a Python run dependency.
  • stage-qa found a couple of issues:
====> Running Q/A tests (stage-qa)
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat'
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps'
Warning: 'lib/mesos/modules/liburi_disk_profile_adaptor-1.8.0.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/mesos/modules/libfixed_resource_estimator-1.8.0.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/mesos/modules/liblogrotate_container_logger-1.8.0.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/mesos/modules/libload_qos_controller-1.8.0.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/libmesos-1.8.0.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: .la libraries found, port needs USES=libtool
Warning: you may not need USES=ssl
*** Error code 1
34–47

The build has -Werror which often leads to build failures on Clang updates, maybe add --disable-werror.

sysutils/apache-mesos/pkg-descr
8

duplicate http://

sysutils/apache-mesos/pkg-plist
11–13

How was pkg-plist generated? etc/mesos should appear as %%ETCDIR%% and share/mesos as %%DATADIR%%.

Are the *.template user-editable (do they need @sample)?

This revision now requires changes to proceed.May 14 2019, 7:41 AM
mat added inline comments.May 14 2019, 11:47 AM
sysutils/apache-mesos/Makefile
11

and "to manager computer clusters" does not either.

tobik resigned from this revision.Jun 2 2019, 1:41 PM

Makefile changes;

  • Fixed incorrect braces for PORTVERSION
  • Added USES= libtool
  • Added USES= shebangfix and SHEBANG_FILES= (although make stage-qa still seems unhappy with these files?)
  • Added USE_LDCONFIG=yes
  • Added option for installing CLI tools (which require the python runtime)
  • Added option for installing Deploy scripts (which should now install the *.template files as samples)
  • Added --disable-werror flag as suggested

pkg-desc changes;

  • Removed duplicate http://

pkg-plist changes;

  • Re-generated using make makeplist
  • Added subs for options (%%CLI%% and %%DEPLOY%%)
james.wright_digital-chaos.com marked 7 inline comments as done.Jun 2 2019, 9:07 PM

Please could take a look over the updated diff, as I appreciate the constructive feedback! :-)