Differential D20251
[new port] sysutils/apache-mesos: Apache Mesos cluster management software Authored by james.wright_digital-chaos.com on May 12 2019, 11:31 PM. Tags Referenced Files
Details
New port for the Apache Mesos cluster management software. This is an initial version to gain some feedback on how the port looks thus far, and currently does not include options to enable Java or Python bindings for simplicity. Bugzilla
Diff Detail
Event Timeline
Comment Actions Makefile changes;
pkg-desc changes;
pkg-plist changes;
Comment Actions Please could take a look over the updated diff, as I appreciate the constructive feedback! :-) Comment Actions Updated to 1.8.1 Comment Actions Looks good to me. If no one objects, I'll commit this after giving it a run in poudriere.
Comment Actions @arrowd: any update on this? Comment Actions Sorry for forgetting about this. I didn't added it to my TODO list. This doesn't build on FreeBSD 12 due to following error: libtool: compile: c++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.8.1\" "-DPACKAGE_STRING=\"mesos 1.8.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.8.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_BOOST_VERSION_HPP=1 -DHAVE_LIBCURL=1 -DHAVE_GLOG_LOGGING_H=1 -DHAVE_ARCHIVE_H=1 -DHAVE_GOOGLE_PROTOBUF_MAP_H=1 -DHAVE_EV_H=1 -DHAVE_PICOJSON_H=1 -DHAVE_RAPIDJSON_RAPIDJSON_H=1 -DHAVE_LIBSASL2=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_GRPCPP_GRPCPP_H=1 -DHAVE_ZOOKEEPER_H=1 -I. -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" -DPKGDATADIR=\"/usr/local/share/mesos\" -DPKGMODULEDIR=\"/usr/local/lib/mesos/modules\" -I../include -I../include -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 -I../3rdparty/leveldb-1.19/include -I../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 -I../3rdparty/stout/include -I/usr/local/include/subversion-1 -I/usr/local/include -I/usr/local/include -I/usr/local/include/apr-1 -I/usr/local/include/apr-1.0 -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/zookeeper -D_THREAD_SAFE -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector-strong -fPIC -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -Wno-unused-local-typedef -Wno-inconsistent-missing-override -std=c++11 -stdlib=libc++ -DGTEST_HAS_PTHREAD -D_WITH_GETLINE -Wno-sentinel -MT master/libmesos_no_3rdparty_la-constants.lo -MD -MP -MF master/.deps/libmesos_no_3rdparty_la-constants.Tpo -c master/constants.cpp -fPIC -DPIC -o master/.libs/libmesos_no_3rdparty_la-constants.o
master/allocator/mesos/hierarchical.cpp:1649:5: error: use of undeclared identifier 'random_shuffle'; did you mean 'std::random_shuffle'?
random_shuffle(resourceVector.begin(), resourceVector.end());
^~~~~~~~~~~~~~
std::random_shuffle
/usr/include/c++/v1/algorithm:3168:1: note: 'std::random_shuffle' declared here
random_shuffle(_RandomAccessIterator __first, _RandomAccessIterator __last)
^Comment Actions I can build this port in poudriere fine. I think previous error was because of patching issue. There are some issues:
====> Running Q/A tests (stage-qa) Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps' Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail' Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat' Error: '/usr/local/bin/python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp' *** Error code 1 I think this is because USE=python:run is only defined when CLI option enabled.
Comment Actions I don't think I need to submit the patch upstream as they have changed this portion of code in their master branch anyway! Comment Actions
Tried moving shebangfix from USES= to CLI_USES= but still get the same error when running make stage-qa. Please could you provide a suggestion how to fix this issue as I'm stumped as to what is the actual problem here. Comment Actions Because python is used for those bin/* files, the quickest way is moving python:run to USE=, however, I tried this and poudriere gives many Error: Orphaned: include/*. Comment Actions Makefile changes
sysutils/Makefile changes
Comment Actions I think the previous errors (regarding python and shebangfix) were caused by a typo in CLI_USES=, I have since updated the diff and they seem to have been resolved. Please could you run a build through poudriere and let me know if there are any outstanding issues? Comment Actions Still: ====> Running Q/A tests (stage-qa) Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-ps' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-tail' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-scp' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/mesos-cat' *** Error code 1 The problem is those files under bin/ need Python, are installed even when CLI is not defined, while python:run and shebangfix are only defined when CLI is on. Comment Actions
I don't think those files should be installed when CLI is not defined, because pkg-plist is as follows; %%CLI%%bin/mesos %%CLI%%bin/mesos-cat %%CLI%%bin/mesos-execute %%CLI%%bin/mesos-local %%CLI%%bin/mesos-log %%CLI%%bin/mesos-ps %%CLI%%bin/mesos-resolve %%CLI%%bin/mesos-scp %%CLI%%bin/mesos-tail I thought this meant that the files would only be installed with CLI defined, is that not the case? Please advise if there is an alternative method to prevent these files being installed if CLI is not defined, and which satisfies the stage-qa tests. Comment Actions
Comment Actions This patch build failed in poudriere: https://gist.github.com/5919089c2e8d247342cf9a8749df7ca7 I added these files in include/ to pkg-plist and it pass the poudriere test. Is that the right fix? (these files need to be installed and installed to the right place) Comment Actions The orphaned files mentioned in that poudriere log were header files I deliberately excluded from the pkg-plist, as I think they are for internal libs and headers only required during the build process, so didn't need to be included in the final package. However it is probably better to package and install them all, in which case your updated pkg-plist looks fine to me! Comment Actions If they do only needed in the process, we can remove them from the package by directly rm them in post-install target. BTW, it fails to build on 11: https://gist.github.com/3d72c1ad6338657c385a86ec8bbb2526 If this is hard to fix, we could consider mark this IGNORE on 11. Comment Actions
After some Googling i think the error shown in the build log occurs when one of the library dependencies (in this case I suspect Boost) has been built without the -fpic (position independant code) flag. I'm not sure why this would happen on 11 and not 12, and I don't have system running 11 to test. Do you have any ideas why the compilation of the libs may be different between 11 and 12? Comment Actions Still fails: https://gist.github.com/987197a48472bfc4790495dfdebab8de Comment Actions What is best way to do this, I tried adding following block near the bottom of the Makfile but portlint complains about it's position no matter where I put it; .include <bsd.port.pre.mk>
.if (${OSVERSION} < 1200000)
IGNORE= build fails on FreeBSD 11
.endifAlso should we use BROKEN= rather than IGNORE= for this case? Comment Actions I would say just add IGNORE_FreeBSD_11= does not build between LICENSE* and *DEPENDS I'm fine with both, IGNORE would tell people don't really need to try it, while BROKEN will still be built by the package builders. Comment Actions
Thanks for advice, I've added the IGNORE_FreeBSD_11= as suggested and portlint is now happy! :-) | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||