Page MenuHomeFreeBSD
Differential D20242

Depessimize arc4rand
ClosedPublic
Actions

Authored by mjg on May 12 2019, 1:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 12, 9:35 AM
Unknown Object (File)
Fri, Sep 11, 1:21 AM
Unknown Object (File)
Thu, Sep 10, 4:05 AM
Unknown Object (File)
Sun, Sep 6, 10:37 AM
Unknown Object (File)
Sun, Sep 6, 12:54 AM
Unknown Object (File)
Fri, Sep 4, 6:52 AM
Unknown Object (File)
Thu, Sep 3, 11:39 AM
Unknown Object (File)
Wed, Sep 2, 10:45 AM
View All Files
Subscribers
delphij
imp

Details

Reviewers
cem
jmg
markm
delphij
Group Reviewers
secteam
Commits
rS347500: random(4): depessimize arc4random
Summary

The function starts with atomic_cmpset_int(&arc4rand_iniseed_state, ARC4_ENTR_HAVE, ARC4_ENTR_SEED), which at least on x86 always dirties the cacheline. I.e. there is perfectly avoidable line bouncing. While here do minor cleanups.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.May 12 2019, 1:52 AM
Herald added a reviewer: jmg. · View Herald TranscriptMay 12 2019, 1:52 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B24208: Diff 57326.May 12 2019, 1:52 AM
cem accepted this revision.May 12 2019, 2:24 AM
cem added a reviewer: markm.
This revision is now accepted and ready to land.May 12 2019, 2:24 AM
delphij accepted this revision.May 12 2019, 4:09 AM
delphij added a subscriber: delphij.

Looks reasonable to me.

Closed by commit rS347500: random(4): depessimize arc4random (authored by mjg). · Explain WhyMay 12 2019, 6:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
libkern/
8 lines

Diff 57331

View Options

head/sys/libkern/arc4random.c

Loading...