Page MenuHomeFreeBSD

[PowerPC64] stand: fix build using clang 8 as compiler
ClosedPublic

Authored by alfredo on Apr 23 2019, 12:34 PM.

Details

Summary

This change fixes "stand" build issues when using clang 8 as compiler.

Test Plan

Tested compile and boot (slof) on powerpc64 QEMU4/pseries on the following compilers:

  • gcc 4.2 - with ELFv1 ABI kernel
  • clang 8.0 - with ELFv2 ABI kernel

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23847
Build 22785: arc lint + arc unit

Event Timeline

alfredo edited the test plan for this revision. (Show Details)
alfredo added a reviewer: jhibbits.
alfredo added subscribers: jhibbits, bdragon, luporl.
cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c
117

This would be better done by casting to uintmax_t and using %jd instead. PRIxxxx is generally frowned upon.

alfredo marked an inline comment as done.
  • jhibbits suggestion

Looks fine to me now. Good work!

This revision is now accepted and ready to land.May 20 2019, 4:20 PM
This revision was automatically updated to reflect the committed changes.