Page MenuHomeFreeBSD
Differential D20026

[PowerPC64] stand: fix build using clang 8 as compiler
ClosedPublic
Actions

Authored by alfredo on Apr 23 2019, 12:34 PM.
Tags
None
Referenced Files
F103119719: D20026.diff
Thu, Nov 21, 6:47 AM
Unknown Object (File)
Sun, Nov 10, 1:48 PM
Unknown Object (File)
Oct 22 2024, 10:36 AM
Unknown Object (File)
Oct 22 2024, 10:36 AM
Unknown Object (File)
Oct 22 2024, 10:36 AM
Unknown Object (File)
Oct 22 2024, 10:36 AM
Unknown Object (File)
Oct 22 2024, 10:28 AM
Unknown Object (File)
Oct 19 2024, 11:26 PM
View All Files
Subscribers
bdragon
delphij
imp
jhibbits
luporl

Details

Reviewers
jhibbits
Commits
rS348683: MFC r348005:
rS348005: [PowerPC64] stand: fix build using clang 8 as compiler
Summary

This change fixes "stand" build issues when using clang 8 as compiler.

Test Plan

Tested compile and boot (slof) on powerpc64 QEMU4/pseries on the following compilers:

  • gcc 4.2 - with ELFv1 ABI kernel
  • clang 8.0 - with ELFv2 ABI kernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alfredo created this revision.Apr 23 2019, 12:34 PM
Herald added a subscriber: delphij. · View Herald TranscriptApr 23 2019, 12:34 PM
Harbormaster completed remote builds in B23847: Diff 56538.Apr 23 2019, 12:34 PM
alfredo edited the summary of this revision. (Show Details)Apr 23 2019, 12:39 PM
alfredo edited the test plan for this revision. (Show Details)
alfredo added a reviewer: jhibbits.
alfredo added subscribers: jhibbits, bdragon, luporl.
jhibbits added inline comments.May 3 2019, 8:20 PM
cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c
117 ↗(On Diff #56538)

This would be better done by casting to uintmax_t and using %jd instead. PRIxxxx is generally frowned upon.

alfredo updated this revision to Diff 57024.May 3 2019, 10:15 PM
alfredo marked an inline comment as done.
  • jhibbits suggestion
Harbormaster completed remote builds in B24091: Diff 57024.May 3 2019, 10:15 PM
alfredo updated this revision to Diff 57025.May 3 2019, 10:17 PM
  • jhibbits suggestion
Harbormaster completed remote builds in B24092: Diff 57025.May 3 2019, 10:17 PM
jhibbits accepted this revision.May 20 2019, 4:20 PM

Looks fine to me now. Good work!

This revision is now accepted and ready to land.May 20 2019, 4:20 PM
Closed by commit rS348005: [PowerPC64] stand: fix build using clang 8 as compiler (authored by luporl). · Explain WhyMay 20 2019, 7:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2019, 7:21 PM

Revision Contents
Changeset List

PathSize
head/
cddl/
contrib/
opensolaris/
lib/
libzfs/
common/
6 lines
stand/
common/
6 lines
ofw/
libofw/
4 lines
1 line
powerpc/
boot1.chrp/
1 line
kboot/
3 lines
10 lines
ofw/
2 lines
2 lines

Diff 57602

View Options

head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c

Loading...
View Options

head/stand/common/load_elf.c

Loading...
View Options

head/stand/ofw/libofw/ofw_net.c

Loading...
View Options

head/stand/ofw/libofw/openfirm.c

Loading...
View Options

head/stand/powerpc/boot1.chrp/boot1.c

Loading...
View Options

head/stand/powerpc/kboot/Makefile

Loading...
View Options

head/stand/powerpc/kboot/main.c

Loading...
View Options

head/stand/powerpc/ofw/elf_freebsd.c

Loading...
View Options

head/stand/powerpc/ofw/ppc64_elf_freebsd.c

Loading...