Page MenuHomeFreeBSD

Don't symlink fusefs.ko to fuse.ko on PPC
ClosedPublic

Authored by asomers on Apr 20 2019, 9:29 PM.

Details

Summary

Don't symlink fusefs.ko to fuse.ko on PPC

Some PPC systems use msdosfs for /boot, which can't handle either symlinks
or hardlinks. So on PPC, copy the module instead. This change fixes
installkernel on such systems after r345350.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Apr 20 2019, 9:29 PM

We only need to maintain "backwards" compatibility in the stable/ branches (12 and 11) as far as I am concerned head can just nuke the compatibilty link, and have a 13.0 release notes item that is "fuse has been renamed to fusefs".

As @rgrimes mentioned on the email thread, can the symlink just summarily be jettisoned, since it was a compat shim within 12? Or am I mistaken, and it's a compat shim in 13?

The symlink is a new addition for 13.0 (and hopefully 12.1). I would be ok with deleting it for 13.0. But how about I commit this change to head first, and then delete the symlink? That will make MFCs cleaner.

jhibbits accepted this revision.Apr 26 2019, 3:27 PM

That idea sounds fine to me. After the MFC, just remove the whole aliasing thing entirely. I have a feeling the number of PowerNV users (the only ones who would see msdosfs /boot) running 12 will be very small compared to those running head.

This revision is now accepted and ready to land.Apr 26 2019, 3:27 PM

The symlink is a new addition for 13.0 (and hopefully 12.1). I would be ok with deleting it for 13.0. But how about I commit this change to head first, and then delete the symlink? That will make MFCs cleaner.

Yes, please. This is the right way to get that compatible link in stable/12 then after MFC you can remove the compat link from head with a MFC: never marker. Thank you!

This revision was automatically updated to reflect the committed changes.