Page MenuHomeFreeBSD
Differential D19968

Improve checksum computation via IPV6_CHECKSUM for received packets
ClosedPublic
Actions

Authored by tuexen on Apr 19 2019, 4:42 PM.
Tags
None
Referenced Files
F166740487: D19968.id56392.diff
Sun, Aug 16, 12:55 AM
Unknown Object (File)
Wed, Aug 12, 5:18 AM
Unknown Object (File)
Tue, Aug 11, 2:43 PM
Unknown Object (File)
Mon, Aug 10, 2:19 PM
Unknown Object (File)
Mon, Aug 10, 9:52 AM
Unknown Object (File)
Sun, Aug 9, 5:21 PM
Unknown Object (File)
Sun, Aug 9, 5:21 PM
Unknown Object (File)
Sun, Aug 9, 5:21 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
bz
jtl
emaste
thj
Commits
rS346402: When a checksum has to be computed for a received IPv6 packet because it
Summary

When computing the checksum for a received packet, ensure that you have enough bytes in the packet such that it contains the checksum. This fixes in particular syzbot, which was injecting an empty (plen = 0) packet, which resulted in a panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 19 2019, 4:42 PM
Herald added subscribers: ae, imp. · View Herald TranscriptApr 19 2019, 4:42 PM
Harbormaster completed remote builds in B23768: Diff 56387.Apr 19 2019, 4:42 PM
bz accepted this revision.Apr 19 2019, 5:06 PM

Again can you please mention "... in rip6_input() ..." in the commit message.

This revision is now accepted and ready to land.Apr 19 2019, 5:06 PM
Closed by commit rS346402: When a checksum has to be computed for a received IPv6 packet because it (authored by tuexen). · Explain WhyApr 19 2019, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netinet6/
3 lines

Diff 56392

View Options

head/sys/netinet6/raw_ip6.c

Loading...