Page MenuHomeFreeBSD

Factor out MBUF hashing code for Ethernet and TCP/IP.
AbandonedPublic

Authored by hselasky on Feb 28 2015, 4:19 PM.
Tags
None
Referenced Files
F101571155: D1987.vs4030.id4032.diff
Thu, Oct 31, 11:21 AM
F101540713: D1987.id4087.diff
Thu, Oct 31, 3:23 AM
Unknown Object (File)
Wed, Oct 30, 3:35 PM
Unknown Object (File)
Wed, Oct 9, 7:33 PM
Unknown Object (File)
Sun, Oct 6, 10:30 PM
Unknown Object (File)
Thu, Oct 3, 3:32 PM
Unknown Object (File)
Sep 28 2024, 10:00 AM
Unknown Object (File)
Sep 23 2024, 12:18 AM
Subscribers
None

Details

Summary

Factor out mbuf hashing code instead of copying it around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hselasky updated this revision to Diff 4030.
hselasky retitled this revision from to Factor out MBUF hashing code for Ethernet and TCP/IP..
hselasky updated this object.
hselasky edited the test plan for this revision. (Show Details)
hselasky added reviewers: glebius, ken, adrian.
hselasky set the repository for this revision to rS FreeBSD src repository - subversion.
hselasky added a subscriber: Unknown Object (MLST).

Add full patch context.

Remove patches not belonging to this issue.

Update patch to latest FreeBSD-11 code and fix some build issues.

Get the directory layout correct.

ae removed a subscriber: Unknown Object (MLST).

It looks like adrian@ already has added number of constants to define hash types in mbuf.h. And there are a lot of room to define other types. Are you sure that it is necessary to add also mask for them?

sys/kern/uipc_mbufhash.c
54

Missing an empty line.

98

"When declaring variables in functions declare them sorted by size, then in alphabetical order; multiple ones per line are okay." (c) style(9) :)

hselasky edited edge metadata.

Address comments from ae @

This patch also adds hashing of "ip6_flow" under MBUF_HASHFLAG_L4, which I consider to be a shortcut for hashing the source and destination ports.

Ping: Anyone planning to give this patch a go or no-go in the near future?

It looks like adrian@ already has added number of constants to define hash types in mbuf.h. And
there are a lot of room to define other types. Are you sure that it is necessary to add also mask for
them?

The hash flags added don't have anything to do with the hash types.

I don't need to add a hash mask.

--HPS

hselasky set the repository for this revision to rS FreeBSD src repository - subversion.

Remove hash mask. Add missing locking in if_lagg.

Committed to FreeBSD-head in r279891.