Differential D19798

if_cgem support for SiFive Unleashed
ClosedPublic
Actions

Authored by br on Apr 2 2019, 5:57 PM.

Details

Reviewers

skibo
markj
mhorne

Commits

rS346634: Add support for Cadence network controller found in HiFive Unleashed board.

Summary

Support for HiFive Unleashed

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Apr 2 2019, 5:57 PM

First disable interrupts and then clear bits.

The approach seems ok to me, but there should probably be a comment explaining why we handle interrupts this way.

To be clear, you are saying that the PLIC claim does not prevent further interrupts from being raised? Is this a known erratum?

Sorry this is a different issue. I simply forgot to implement pre_ithread, post_ithread methods in the interrupt controller driver where we have to disable and enable interrupts. I will update patch shortly

Interrupts have to be disabled in PLIC driver when we process it in the interrupt thread.

The new diff doesn't modify the PLIC driver.

In D19798#424970, @markj wrote:

The new diff doesn't modify the PLIC driver.

I think PLIC changes are not related, so I create another diff:
https://reviews.freebsd.org/D19819

markj accepted this revision.Apr 4 2019, 11:05 PM

This revision is now accepted and ready to land.Apr 4 2019, 11:05 PM

Closed by commit rS346634: Add support for Cadence network controller found in HiFive Unleashed board. (authored by br). · Explain WhyApr 24 2019, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 24 2019, 1:44 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cadence/

if_cgem.c

8 lines

Diff 56585

View Options

head/sys/dev/cadence/if_cgem.c

if_cgem support for SiFive UnleashedClosedPublicActions