Page MenuHomeFreeBSD
Differential D19772

x11/terminology: Update to 1.4.0
ClosedPublic
Actions

Authored by cem on Mar 31 2019, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 2:32 AM
Unknown Object (File)
Thu, Nov 27, 10:08 AM
Unknown Object (File)
Fri, Nov 21, 11:06 AM
Unknown Object (File)
Fri, Nov 21, 11:03 AM
Unknown Object (File)
Fri, Nov 21, 11:02 AM
Unknown Object (File)
Fri, Nov 21, 11:02 AM
Unknown Object (File)
Fri, Nov 21, 11:01 AM
Unknown Object (File)
Fri, Nov 21, 10:59 AM
View All Files
Subscribers
0mp
jrm
mat

Details

Reviewers
gblach
0mp
jrm
Group Reviewers
Ports Committers
Commits
rP497493: x11/terminology: Update to 1.4.0

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem created this revision.Mar 31 2019, 9:21 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 31 2019, 9:21 PM
Harbormaster completed remote builds in B23426: Diff 55657.Mar 31 2019, 9:21 PM
cem added a reviewer: Ports Committers.Mar 31 2019, 9:21 PM
jrm added a subscriber: jrm.Mar 31 2019, 9:30 PM

portlint asks for INSTALLS_ICONS.

x11/terminology/Makefile
5 ↗(On Diff #55657)

Nit-pick: Porter's Handbook prefers DISTVERSION here.

16 ↗(On Diff #55657)

Nit-pick: This should go after MASTER_SITES.

cem planned changes to this revision.Apr 1 2019, 5:53 AM

Thanks @jrm!

Will fix these preexisting issues at the same time.

cem marked 2 inline comments as done.Apr 1 2019, 5:59 AM
In D19772#423875, @jrm wrote:

portlint asks for INSTALLS_ICONS.

It seems this may be a false positive? INSTALLS_ICONS is for USES= GNOME ports; this port does not use Gtk or GNOME at all.

cem updated this revision to Diff 55661.Apr 1 2019, 6:06 AM

Fix existing style issues in the port

Harbormaster completed remote builds in B23429: Diff 55661.Apr 1 2019, 6:06 AM
0mp accepted this revision.Apr 1 2019, 7:29 AM
0mp added a subscriber: 0mp.

LGTM

x11/terminology/Makefile
13 ↗(On Diff #55661)

Nit picking: if there is a LICENSE_FILE somewhere there, I'd add it.

This revision is now accepted and ready to land.Apr 1 2019, 7:29 AM
jrm accepted this revision.Apr 1 2019, 11:39 AM

lgtm

cem updated this revision to Diff 55679.Apr 1 2019, 4:44 PM
cem marked an inline comment as done.

Tag COPYING as LICENSE_FILE per 0mp@

This revision now requires review to proceed.Apr 1 2019, 4:44 PM
Harbormaster completed remote builds in B23441: Diff 55679.Apr 1 2019, 4:44 PM
jrm accepted this revision as: jrm.Apr 1 2019, 4:45 PM
This revision is now accepted and ready to land.Apr 1 2019, 4:45 PM
Closed by commit rP497493: x11/terminology: Update to 1.4.0 (authored by cem). · Explain WhyApr 1 2019, 4:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
x11/
terminology/
5 lines
6 lines

Diff 55680

View Options

head/x11/terminology/Makefile

Loading...
View Options

head/x11/terminology/distinfo

Loading...