Page MenuHomeFreeBSD

x11/terminology: Update to 1.4.0
ClosedPublic

Authored by cem on Mar 31 2019, 9:21 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cem created this revision.Mar 31 2019, 9:21 PM
jrm added a subscriber: jrm.Mar 31 2019, 9:30 PM

portlint asks for INSTALLS_ICONS.

x11/terminology/Makefile
5 ↗(On Diff #55657)

Nit-pick: Porter's Handbook prefers DISTVERSION here.

16 ↗(On Diff #55657)

Nit-pick: This should go after MASTER_SITES.

cem planned changes to this revision.Apr 1 2019, 5:53 AM

Thanks @jrm!

Will fix these preexisting issues at the same time.

cem marked 2 inline comments as done.Apr 1 2019, 5:59 AM
In D19772#423875, @jrm wrote:

portlint asks for INSTALLS_ICONS.

It seems this may be a false positive? INSTALLS_ICONS is for USES= GNOME ports; this port does not use Gtk or GNOME at all.

cem updated this revision to Diff 55661.Apr 1 2019, 6:06 AM

Fix existing style issues in the port

0mp accepted this revision.Apr 1 2019, 7:29 AM
0mp added a subscriber: 0mp.

LGTM

x11/terminology/Makefile
13 ↗(On Diff #55661)

Nit picking: if there is a LICENSE_FILE somewhere there, I'd add it.

This revision is now accepted and ready to land.Apr 1 2019, 7:29 AM
cem marked an inline comment as done.Apr 1 2019, 4:44 PM
cem updated this revision to Diff 55679.

Tag COPYING as LICENSE_FILE per 0mp@

This revision now requires review to proceed.Apr 1 2019, 4:44 PM
jrm accepted this revision as: jrm.Apr 1 2019, 4:45 PM
This revision is now accepted and ready to land.Apr 1 2019, 4:45 PM
This revision was automatically updated to reflect the committed changes.