Page MenuHomeFreeBSD

Spam CXXFLAGS with `-I${DESTDIR}/usr/include/private`, instead of GTEST_CXXFLAGS
ClosedPublic

Authored by ngie on Mar 28 2019, 12:30 AM.
Tags
None
Referenced Files
F82858867: D19731.id55544.diff
Fri, May 3, 7:03 AM
F82858863: D19731.id55521.diff
Fri, May 3, 7:03 AM
F82853947: D19731.id.diff
Fri, May 3, 5:44 AM
F82838932: D19731.diff
Fri, May 3, 1:29 AM
Unknown Object (File)
Dec 20 2023, 6:02 AM
Unknown Object (File)
Nov 7 2023, 10:56 AM
Unknown Object (File)
Oct 6 2023, 9:55 AM
Unknown Object (File)
Sep 10 2023, 8:42 AM
Subscribers

Details

Summary

This makes it easier for googletest users to leverage googletest, instead of
having to plug GTEST_CXXFLAGS into CXXFLAGS manually.

I will be following this up with a more proper fix in src.libnames.mk, as
src.libnames.mk should be automatically adding this directory to
CFLAGS/CXXFLAGS when private libraries are referenced. Not doing so can result
in mismatches between base-provided private library and ports-provided library
headers.

MFC after: 5 weeks
MFC with: r345203

Test Plan

make buildworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This change doesn't work for me. I still need the CXXFLAGS+= ${GTESTS_CXXFLAGS} line in my Makefile.

Nevermind, I patched the wrong file. This change works fine for my test suite, where the supporting files don't need the full GTESTS_CXXFLAGS settings like -DGTEST_HAS_PTHREAD etc.

This revision is now accepted and ready to land.Mar 28 2019, 4:11 AM

Approved, please make reference to the goals of the more proper future fix in the commit message.

Approved, please make reference to the goals of the more proper future fix in the commit message.

Will do!

ngie edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.