Page MenuHomeFreeBSD

Enable NVMe on aarch64
ClosedPublic

Authored by greg_unrelenting.technology on Mar 20 2019, 11:01 AM.

Details

Summary

Required for (and tested on) AWS EC2 a1 instances.

Let's use nda by default just like powerpc64 does,.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Aside from the whitespace issue, I'm ready to commit this unless any of the arm-y people object.

sys/arm64/conf/GENERIC
176 ↗(On Diff #55276)

This should be "options<space><tab>..." . (see sys/conf/NOTES -- this is an old FreeBSD custom which results in tab alignment working even in patches)

sys/arm64/conf/GENERIC
176 ↗(On Diff #55276)

oh. I copy-pasted from powerpc/conf/GENERIC64 — the space wasn't there

imp accepted this revision.Mar 20 2019, 9:57 PM

+1 on cperciva's spacing nits.

This revision is now accepted and ready to land.Mar 20 2019, 9:57 PM
This revision now requires review to proceed.Mar 20 2019, 10:15 PM
greg_unrelenting.technology marked an inline comment as done.Mar 20 2019, 10:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2019, 6:36 AM
This revision was automatically updated to reflect the committed changes.