Differential D19579

Fix bhyve's NVMe Identify Namespace data
ClosedPublic
Actions

Authored by chuck on Mar 14 2019, 9:48 AM.

Details

Reviewers

imp
ken
araujo
jhb
rgrimes

Group Reviewers

bhyve

Commits

rS345170: Fix bhyve's NVMe Identify Namespace data

Summary

The NVMe Identify Namespace data structure's Number of LBA Formats
(NLBAF) field is a 0's based value (i.e. 0x0 means 1). Since the
emulation only supports a single format, set NLBAF to 0x0, not 1.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chuck created this revision.Mar 14 2019, 9:48 AM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 14 2019, 9:48 AM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

Harbormaster completed remote builds in B23079: Diff 55048.Mar 14 2019, 9:48 AM

style(9)

Harbormaster completed remote builds in B23080: Diff 55049.Mar 14 2019, 9:49 AM

chuck added reviewers: imp, ken, araujo.Mar 14 2019, 9:50 AM

rgrimes accepted this revision as: rgrimes.Mar 14 2019, 11:29 AM

rgrimes added a reviewer: jhb.

This revision is now accepted and ready to land.Mar 14 2019, 11:30 AM

imp accepted this revision.Mar 14 2019, 11:18 PM

LGTM!

Closed by commit rS345170: Fix bhyve's NVMe Identify Namespace data (authored by chuck). · Explain WhyMar 15 2019, 2:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

pci_nvme.c

2 lines

Diff 55086

View Options

head/usr.sbin/bhyve/pci_nvme.c

Fix bhyve's NVMe Identify Namespace dataClosedPublicActions