Page MenuHomeFreeBSD

Divorce MK_GDB from MK_BINUTILS.
ClosedPublic

Authored by jhb on Mar 6 2019, 6:05 PM.

Details

Summary

This permits legacy GDB to still be built and installed if
WITHOUT_BINUTILS is set (e.g. if base/binutils is installed).

Test Plan
  • used in an amd64 VM using base/* as the toolchain to still get a /usr/libexec/kgdb for crashinfo
  • passed make tinderbox

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

You'll want to update the WITH_/WITHOUT_BINUTILS files too

Modulo the WITH/WITHOUT updates, looks good

This revision is now accepted and ready to land.Mar 6 2019, 6:13 PM

You'll want to update the WITH_/WITHOUT_BINUTILS files too

Hmm, I looked at those but they don't reference gdb at all. However, regenerating src.conf.5 did generate a diff I'll upload in a sec.

This revision now requires review to proceed.Mar 6 2019, 7:05 PM
In D19480#417046, @jhb wrote:

Hmm, I looked at those but they don't reference gdb at all. However, regenerating src.conf.5 did generate a diff I'll upload in a sec.

Oh, I thought they made reference to gdb, but you're right, they already describe only the binutils not controlled by MK_GDB.

This revision is now accepted and ready to land.Mar 6 2019, 7:10 PM
This revision was automatically updated to reflect the committed changes.