Page MenuHomeFreeBSD

Update multimedia/emby-server to

Authored by on Feb 8 2019, 7:57 PM.



This patch updates emby-server to the latest and greatest version which brings multiple improvements.
Release Notes:

This patch also unbreaks the current emby-server port which experiences shared library errors.
Shared library errors:

Test Plan

QA checked:
portlint -ac
poudriere testport -j head
poudriere testport -j stable12
poudriere testport -j stable11

Emby-server has been running fine on my system based on the provided patch.

Diff Detail

rP FreeBSD ports repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich added subscribers: multimedia, jbeich.

multimedia doesn't maintain this port. Redirecting to the larger pool of ports/ committers.

tcberner added inline comments.
8 ↗(On Diff #53710)

^ you could probably get away with setting DISTVERSIONPREFIX=netframework_

10 ↗(On Diff #53710)

^can't you use the ffmpeg from ports?

2 ↗(On Diff #53710)

^ this should probably be called %%LOCALBASE%%

2 ↗(On Diff #53710)


1 ↗(On Diff #53710)

^ why not just add lame as a fixed dependency / make it default on?

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

8 ↗(On Diff #53710)

Mmm, but PORTNAME is emby-server, and DISTNAME as embyserver, it would not change a lot, except defining one more variable.

52 ↗(On Diff #53710)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

(Should go in the USES block)

73–104 ↗(On Diff #53710)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

(Should go before options)

108–110 ↗(On Diff #53710)

For single files, please use the INSTALL_* macros.

1 ↗(On Diff #53710)

Probably because of license. Either the port has a package, or it has LAME on and has no package, so it still has to be built manually. marked an inline comment as done.

Address comments from mat & tcberner added inline comments.
10 ↗(On Diff #53710)

Emby uses a customized ffmpeg with local patches to provide features and tailor it for Emby. For example, transcoding throttling which is a big feature for this release. I asked if they can upstream as much as possible, as it would be a lot cleaner if we could depend on the ffmpeg in our tree. Although, I don't see this happening in the short term.


1 ↗(On Diff #53710)

Exactly this!

9 ↗(On Diff #53728)

This should be ${DISTNAME}.zip.

12 ↗(On Diff #53728)

This file name is too generic, please use DIST_SUBDIR.

13 ↗(On Diff #53728)

DISTNAME here too.

60 ↗(On Diff #53728)

Are you sure about this one?

62–63 ↗(On Diff #53728)

Why +=?

  • Address mat comments
  • Remove unneeded clutter in rc script
  • Streamline ffmpeg configure args

Rechecked QA with poudriere testport and portlint.

60 ↗(On Diff #53728)

I have tried building the ffmpeg without this set but then it fails to build.

lwhsu added a subscriber: lwhsu.
lwhsu added inline comments.
1 ↗(On Diff #53739)

@woodsb02 Ben, are you OK for removing this line?

47 ↗(On Diff #53739)

Is tar:xz needed?

1 ↗(On Diff #53739)

Yes added inline comments.
47 ↗(On Diff #53739)

Good catch! Its not needed anymore; updated diff accordingly.

26 ↗(On Diff #53842)

PREFIX (Actually, you copied the typo.) marked an inline comment as done.

Fix typo's in RC script.

66 ↗(On Diff #53926)

No need for += either.

Remove unneeded += for configure args. retitled this revision from Update multimedia/emby-server to to Update multimedia/emby-server to
  • Upstream released Emby-server so update to latest version
  • Link ffmpeg with x265
  • Remove X11 as option (as it defaulted to on anyway and USE_XORG=x11 is set)

Retested QA with poudriere testport and portlint -ac. edited the test plan for this revision. (Show Details)

Re-add X11 option as there is interest for this in the community and an extra option doesn't hurt anyway.
Also handy for people wanting to keep their system clean of X11 and extra libraries.

This is the final diff from my part. If a committer could go over it one last time :).
Thanks to everyone who has helped getting this reviewed!

QA checked:
Poudriere testport
Portlint -ac

I think this is fine. @mat , I'm going to commit this patch, are you ok with this?

This revision is now accepted and ready to land.Feb 26 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.