Page MenuHomeFreeBSD

Update multimedia/emby-server to 4.0.2.0
Needs ReviewPublic

Authored by driesm.michiels_gmail.com on Fri, Feb 8, 7:57 PM.

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
Summary

This patch updates emby-server to the latest and greatest version which brings multiple improvements.
Release Notes: https://emby.media/community/index.php?/blog/1/entry-447-announcing-emby-server-40/

This patch also unbreaks the current emby-server port which experiences shared library errors.
Shared library errors: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232966

Test Plan

QA checked:
portlint -ac
poudriere testport -j head
poudriere testport -j stable12
poudriere testport -j stable11

Emby-server 4.0.1.0 has been running fine on my system based on the provided patch.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jbeich added subscribers: multimedia, jbeich.

multimedia doesn't maintain this port. Redirecting to the larger pool of ports/ committers.

tcberner added inline comments.
multimedia/emby-server/Makefile
8

^ you could probably get away with setting DISTVERSIONPREFIX=netframework_

10

^can't you use the ffmpeg from ports?

multimedia/emby-server/files/ImageMagickSharp.dll.config.in
3

^ this should probably be called %%LOCALBASE%%

multimedia/emby-server/files/SQLitePCLRaw.provider.sqlite3.dll.config.in
3

^same

multimedia/emby-server/pkg-message
1–2

^ why not just add lame as a fixed dependency / make it default on?

mat added a comment.Sat, Feb 9, 8:56 AM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

multimedia/emby-server/Makefile
8

Mmm, but PORTNAME is emby-server, and DISTNAME as embyserver, it would not change a lot, except defining one more variable.

52

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

(Should go in the USES block)

73–104

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

(Should go before options)

108–110

For single files, please use the INSTALL_* macros.

multimedia/emby-server/pkg-message
1–2

Probably because of license. Either the port has a package, or it has LAME on and has no package, so it still has to be built manually.

driesm.michiels_gmail.com marked an inline comment as done.

Address comments from mat & tcberner

driesm.michiels_gmail.com marked 5 inline comments as done.Sat, Feb 9, 12:22 PM
driesm.michiels_gmail.com added inline comments.
multimedia/emby-server/Makefile
10

Emby uses a customized ffmpeg with local patches to provide features and tailor it for Emby. For example, transcoding throttling which is a big feature for this release. I asked if they can upstream as much as possible, as it would be a lot cleaner if we could depend on the ffmpeg in our tree. Although, I don't see this happening in the short term.

FYI: https://emby.media/community/index.php?/topic/12906-freebsd-package/?p=677067

multimedia/emby-server/pkg-message
1–2

Exactly this!

mat added inline comments.Sun, Feb 10, 7:47 AM
multimedia/emby-server/Makefile
9

This should be ${DISTNAME}.zip.

12

This file name is too generic, please use DIST_SUBDIR.

13

DISTNAME here too.

63

Are you sure about this one?

65–66

Why +=?

  • Address mat comments
  • Remove unneeded clutter in rc script
  • Streamline ffmpeg configure args

Rechecked QA with poudriere testport and portlint.

driesm.michiels_gmail.com marked 7 inline comments as done.Sun, Feb 10, 3:29 PM
multimedia/emby-server/Makefile
63

I have tried building the ffmpeg without this set but then it fails to build.

lwhsu added a subscriber: lwhsu.Tue, Feb 12, 7:57 AM
lwhsu added a subscriber: woodsb02.
lwhsu added inline comments.
multimedia/emby-server/Makefile
1

@woodsb02 Ben, are you OK for removing this line?

mat added inline comments.Tue, Feb 12, 12:11 PM
multimedia/emby-server/Makefile
49

Is tar:xz needed?

woodsb02 added inline comments.Tue, Feb 12, 1:23 PM
multimedia/emby-server/Makefile
1

Yes

Remove unneeded use of tar:xz.

driesm.michiels_gmail.com marked an inline comment as done.Tue, Feb 12, 6:40 PM
driesm.michiels_gmail.com added inline comments.
multimedia/emby-server/Makefile
49

Good catch! Its not needed anymore; updated diff accordingly.

miwi added a subscriber: miwi.Wed, Feb 13, 3:32 AM
mat added inline comments.Thu, Feb 14, 11:37 AM
multimedia/emby-server/files/emby-server.in
26

PREFIX (Actually, you copied the typo.)

driesm.michiels_gmail.com marked an inline comment as done.

Fix typo's in RC script.

driesm.michiels_gmail.com marked an inline comment as done.Thu, Feb 14, 5:03 PM
mat added inline comments.Fri, Feb 15, 11:28 AM
multimedia/emby-server/Makefile
68

No need for += either.

Remove unneeded += for configure args.

driesm.michiels_gmail.com marked an inline comment as done.Fri, Feb 15, 5:51 PM
driesm.michiels_gmail.com retitled this revision from Update multimedia/emby-server to 4.0.1.0 to Update multimedia/emby-server to 4.0.2.0.
  • Upstream released Emby-server 4.0.2.0 so update to latest version
  • Link ffmpeg with x265
  • Remove X11 as option (as it defaulted to on anyway and USE_XORG=x11 is set)

Retested QA with poudriere testport and portlint -ac.