Page MenuHomeFreeBSD

- Fix Headset sound for DELL laptops
ClosedPublic

Authored by miwi on Jan 29 2019, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 5 2024, 6:06 PM
Unknown Object (File)
Jan 29 2024, 5:14 AM
Unknown Object (File)
Jan 25 2024, 6:22 AM
Unknown Object (File)
Jan 22 2024, 9:51 AM
Unknown Object (File)
Jan 21 2024, 6:28 PM
Unknown Object (File)
Jan 12 2024, 10:25 AM
Unknown Object (File)
Dec 20 2023, 5:40 AM
Unknown Object (File)
Dec 20 2023, 1:14 AM

Details

Summary
  • Fixes sound on headset jack for ALC255 and ALC256 codec like DELL Inspirion 7577,

Vostro 15-3568, Latitude 7370, Inspiron 15-3552 and Inspiron 15-3567.

PR: 219350 [1], [2]

https://github.com/trueos/trueos/pull/279 [3]

Submitted by: Masachika ISHIZUKA (ish_at_amail.plala.or.jp) [1]

Neel Chauhan (neel_at_neelc.org) [2]
Yuri Momotyuk (yurkis_at_gmail.com) [3]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22248
Build 21451: arc lint + arc unit

Event Timeline

araujo added a reviewer: mav.

I have added @mav as a reviewer, I know he has worked with the hda drivers before.

@mav do you mind take a look on this patch too?

It looks good to me.

@miwi wait for @mav review before proceed with the commit.

Best,

This revision is now accepted and ready to land.Feb 22 2019, 1:18 AM
0mp added inline comments.
sys/dev/sound/pci/hda/hdaa_patches.c
784

I am not sure but isn't there an extra leading tab?

I have no objections, but I have no documentation to know what that coefficient being set means.

Also just curios, why have you used if statement instead of continuing switch just above.

Please commit this simple patch and MFC to 12 before code slush phase begins.

Ok, I'm gonna do it tomorrow!!!