Page MenuHomeFreeBSD
Differential D19017

- Fix Headset sound for DELL laptops
ClosedPublic
Actions

Authored by miwi on Jan 29 2019, 2:47 PM.
Tags
None
Referenced Files
F82066898: D19017.diff
Thu, Apr 25, 5:04 AM
Unknown Object (File)
Sat, Apr 20, 7:28 PM
Unknown Object (File)
Sat, Apr 20, 2:19 PM
Unknown Object (File)
Feb 5 2024, 6:06 PM
Unknown Object (File)
Jan 29 2024, 5:14 AM
Unknown Object (File)
Jan 25 2024, 6:22 AM
Unknown Object (File)
Jan 22 2024, 9:51 AM
Unknown Object (File)
Jan 21 2024, 6:28 PM
View All 38 Files
Subscribers
0mp
bostwickbrian_gmail.com
cillonimarco_gmail.com
imp
rlibby
yurkis_gmail.com
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
araujo
mav
Commits
rS351541: MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec.
rS350433: Fix sound on headset jack for ALC255 and ALC256 codec.
Summary
  • Fixes sound on headset jack for ALC255 and ALC256 codec like DELL Inspirion 7577,

Vostro 15-3568, Latitude 7370, Inspiron 15-3552 and Inspiron 15-3567.

PR: 219350 [1], [2]

https://github.com/trueos/trueos/pull/279 [3]

Submitted by: Masachika ISHIZUKA (ish_at_amail.plala.or.jp) [1]

Neel Chauhan (neel_at_neelc.org) [2]
Yuri Momotyuk (yurkis_at_gmail.com) [3]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

miwi created this revision.Jan 29 2019, 2:47 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 29 2019, 2:47 PM
Harbormaster completed remote builds in B22247: Diff 53375.Jan 29 2019, 2:47 PM
miwi updated this revision to Diff 53377.Jan 29 2019, 2:56 PM
  • space and tab fixes
Harbormaster completed remote builds in B22248: Diff 53377.Jan 29 2019, 2:56 PM
yurkis_gmail.com added a subscriber: yurkis_gmail.com.Jan 30 2019, 11:17 AM
miwi edited the summary of this revision. (Show Details)Jan 30 2019, 11:23 AM
bostwickbrian_gmail.com added a subscriber: bostwickbrian_gmail.com.Jan 30 2019, 7:41 PM
cillonimarco_gmail.com added a subscriber: cillonimarco_gmail.com.Feb 13 2019, 6:07 PM
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Feb 20 2019, 10:10 AM
araujo accepted this revision.Feb 22 2019, 1:16 AM
araujo added a reviewer: mav.

I have added @mav as a reviewer, I know he has worked with the hda drivers before.

@mav do you mind take a look on this patch too?

It looks good to me.

@miwi wait for @mav review before proceed with the commit.

Best,

This revision is now accepted and ready to land.Feb 22 2019, 1:18 AM
0mp added a subscriber: 0mp.Feb 23 2019, 6:04 PM
0mp added inline comments.
sys/dev/sound/pci/hda/hdaa_patches.c
784 ↗(On Diff #53377)

I am not sure but isn't there an extra leading tab?

mav accepted this revision.Feb 28 2019, 1:34 PM

I have no objections, but I have no documentation to know what that coefficient being set means.

Also just curios, why have you used if statement instead of continuing switch just above.

rlibby added a subscriber: rlibby.Jul 3 2019, 5:45 PM
zarychtam_plan-b.pwste.edu.pl added a comment.Jul 28 2019, 12:00 PM

Please commit this simple patch and MFC to 12 before code slush phase begins.

araujo added a comment.Jul 28 2019, 12:10 PM

Ok, I'm gonna do it tomorrow!!!

Closed by commit rS350433: Fix sound on headset jack for ALC255 and ALC256 codec. (authored by araujo). · Explain WhyJul 30 2019, 2:02 AM
This revision was automatically updated to reflect the committed changes.
araujo added a commit: rS350433: Fix sound on headset jack for ALC255 and ALC256 codec..
araujo added a commit: rS351541: MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec..Aug 27 2019, 7:17 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sound/
pci/
hda/
17 lines
1 line

Diff 60263

View Options

head/sys/dev/sound/pci/hda/hdaa_patches.c

Loading...
View Options

head/sys/dev/sound/pci/hda/hdac.h

Loading...