Paths

Table of Contentst

Unbreak the build on 32-bit architectures
ClosedPublic
Actions

Authored by ngie on Jan 23 2019, 11:18 PM.

Details

Reviewers

asomers
emaste
jtl

Commits

rS343367: Unbreak the build on architectures where size_t isn't synonymous with uintmax_t

Summary

I should have used %zu instead of %ju with size_t types.

MFC after: 1 month
MFC with: r343362, r343365
Pointyhat to: ngie

Test Plan

Does it compile :)?

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Jan 23 2019, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2019, 11:18 PM

Harbormaster completed remote builds in B22103: Diff 53129.Jan 23 2019, 11:18 PM

Instead of casting the argument to a larger size, can you just use %zu instead?

Long story short...
bart-simpson-make-universe

In D18935#404443, @asomers wrote:

Instead of casting the argument to a larger size, can you just use %zu instead?

Yup *derp*!

ngie edited the summary of this revision. (Show Details)Jan 23 2019, 11:26 PM

Use %zu instead of %ju, like I should have done in the beginning

Harbormaster completed remote builds in B22104: Diff 53130.Jan 23 2019, 11:27 PM

Approved. Just make sure the commit message matches the code.

This revision is now accepted and ready to land.Jan 23 2019, 11:27 PM

In D18935#404452, @asomers wrote:

Approved. Just make sure the commit message matches the code.

Done -- thanks!

Closed by commit rS343367: Unbreak the build on architectures where size_t isn't synonymous with uintmax_t (authored by ngie). · Explain WhyJan 23 2019, 11:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

tests/

sys/

sendfile_test.c

4 lines

Diff 53131

View Options

head/lib/libc/tests/sys/sendfile_test.c

Unbreak the build on 32-bit architecturesClosedPublicActions