Page MenuHomeFreeBSD

Unbreak the gcc build with sendfile_test after r343362
ClosedPublic

Authored by ngie on Jan 23 2019, 10:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 9:53 AM
Unknown Object (File)
Jan 31 2024, 5:13 AM
Unknown Object (File)
Dec 20 2023, 1:03 PM
Unknown Object (File)
Dec 20 2023, 2:02 AM
Unknown Object (File)
Dec 12 2023, 8:47 AM
Unknown Object (File)
Nov 14 2023, 4:52 AM
Unknown Object (File)
Nov 4 2023, 12:45 PM
Unknown Object (File)
Oct 29 2023, 8:15 AM
Subscribers

Details

Summary

gcc 8.x is more pedantic than clang 7.x with format strings and the tests
passed void* variables while supplying %s (which is technically
incorrect).

Make the affected void* variables use char* storage instead to address
this issue, as the compiler will upcast the values to char*.

MFC after: 1 month
MFC with: r343362

Test Plan
make; sudo make install; kyua test -k /usr/tests/lib/libc/sys/Kyuafile sendfile_test

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

This revision is now accepted and ready to land.Jan 23 2019, 10:56 PM

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

It should work. The Committer's Guide was updated to use MFC with instead of X-MFC-With (the old form): https://www.freebsd.org/doc/en/articles/committers-guide/article.html#commit-log-message back almost 2 years ago by @emaste: https://svnweb.freebsd.org/doc?view=revision&revision=50227 ;).

This revision was automatically updated to reflect the committed changes.
In D18934#404425, @ngie wrote:

Approved. But I think the MFC reminder won't work unless you replace "MFC With" with "X-MFC-With" in your commit message.

It should work. The Committer's Guide was updated to use MFC with instead of X-MFC-With (the old form): https://www.freebsd.org/doc/en/articles/committers-guide/article.html#commit-log-message back almost 2 years ago by @emaste: https://svnweb.freebsd.org/doc?view=revision&revision=50227 ;).

Oh, that's news to me. I guess I should reread the committer's guide every five years or so.