Page MenuHomeFreeBSD

fix rtld-elf compilation warning for powerpc64 ELFv2 ABI
ClosedPublic

Authored by alfredo.junior_eldorado.org.br on Thu, Jan 10, 12:05 PM.

Details

Summary

reloc_jmpslot function parameter 'defobj' is not used when using ELFv2 ABI

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib added inline comments.Thu, Jan 10, 12:30 PM
libexec/rtld-elf/powerpc64/reloc.c
450 ↗(On Diff #52730)

You can add __unused attribute to the argument. It is innocent when not true.

luporl added a subscriber: luporl.Thu, Jan 10, 2:50 PM

as per review, added __unused attributed instead

emaste accepted this revision.Thu, Jan 10, 3:22 PM
This revision is now accepted and ready to land.Thu, Jan 10, 3:22 PM
jhibbits accepted this revision.Thu, Jan 10, 3:28 PM
kib accepted this revision.Thu, Jan 10, 3:28 PM

OK, I'm fine with this solution.

This revision was automatically updated to reflect the committed changes.