Page MenuHomeFreeBSD
Differential D18808

fix rtld-elf compilation warning for powerpc64 ELFv2 ABI
ClosedPublic
Actions

Authored by alfredo on Jan 10 2019, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 1:22 AM
Unknown Object (File)
Tue, Nov 4, 2:46 AM
Unknown Object (File)
Sun, Nov 2, 2:37 PM
Unknown Object (File)
Sun, Oct 26, 5:25 PM
Unknown Object (File)
Sun, Oct 26, 1:26 AM
Unknown Object (File)
Sat, Oct 25, 12:42 PM
Unknown Object (File)
Sat, Oct 25, 12:42 PM
Unknown Object (File)
Sat, Oct 25, 12:42 PM
View All Files
Subscribers
bdragon
imp
luporl
Contributor Reviews (src)

Details

Reviewers
kib
bdragon
emaste
jhibbits
Commits
rS342985: Fix rtld-elf compilation warning for powerpc64 ELFv2 ABI
Summary

reloc_jmpslot function parameter 'defobj' is not used when using ELFv2 ABI

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alfredo created this revision.Jan 10 2019, 12:05 PM
Herald added subscribers: Contributor Reviews (src), bdragon, imp. · View Herald TranscriptJan 10 2019, 12:05 PM
Harbormaster completed remote builds in B21912: Diff 52730.Jan 10 2019, 12:05 PM
alfredo edited the summary of this revision. (Show Details)Jan 10 2019, 12:23 PM
alfredo added reviewers: kib, bdragon.
kib added inline comments.Jan 10 2019, 12:30 PM
libexec/rtld-elf/powerpc64/reloc.c
450 ↗(On Diff #52730)

You can add __unused attribute to the argument. It is innocent when not true.

luporl added a subscriber: luporl.Jan 10 2019, 2:50 PM
alfredo added reviewers: emaste, jhibbits.Jan 10 2019, 3:11 PM
alfredo updated this revision to Diff 52742.Jan 10 2019, 3:15 PM

as per review, added __unused attributed instead

Harbormaster completed remote builds in B21917: Diff 52742.Jan 10 2019, 3:15 PM
emaste accepted this revision.Jan 10 2019, 3:22 PM
This revision is now accepted and ready to land.Jan 10 2019, 3:22 PM
jhibbits accepted this revision.Jan 10 2019, 3:28 PM
kib accepted this revision.Jan 10 2019, 3:28 PM
bdragon accepted this revision.Jan 10 2019, 4:14 PM

OK, I'm fine with this solution.

bdragon mentioned this in D18565: Fix warning in PowerPC64 ELFv2 build of rtld-elf..Jan 10 2019, 4:17 PM
Closed by commit rS342985: Fix rtld-elf compilation warning for powerpc64 ELFv2 ABI (authored by jhibbits). · Explain WhyJan 13 2019, 2:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
libexec/
rtld-elf/
powerpc64/
2 lines

Diff 52803

View Options

head/libexec/rtld-elf/powerpc64/reloc.c

Loading...