Page MenuHomeFreeBSD

sysutils/consolekit2: enable drm/evdev, fix drm device recognition
ClosedPublic

Authored by val_packett.cool on Jan 5 2019, 1:55 PM.
Tags
None
Referenced Files
F80140098: D18754.id.diff
Thu, Mar 28, 11:41 AM
Unknown Object (File)
Feb 23 2024, 4:53 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM
Unknown Object (File)
Feb 9 2024, 3:26 AM

Details

Summary

This makes it possible to launch a Wayland compositor using ConsoleKit2 as the session controller.

Test Plan

Tested a lot with patched wlroots (we should merge this patch in the wlroots port), a bit with patched weston, and even kwin sort of worked once

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Cool, I'll try if I manage to start it.

+ fix re-plugging devices by checking if the found device is still alive

Submitted upstream, but the project isn't very active, there are three open PRs and they got no response

oh, it also didn't enable termios raw mode. That was causing Weston to crash when pressing Enter :D Fixed.

This seems to look good, but I don't have a setup to test this.

Lets poke the KDE people :-)

looks like it would need a revision bump aswell.

Tryign to ck-launch-session /usr/local/bin/startplasmacompositor leads to a segfault ck.

Tryign to ck-launch-session /usr/local/bin/startplasmacompositor leads to a segfault ck.

huh. So I tried it, ck works fine, KWin however wasn't actually ported to FreeBSD…

I made an attempt: https://reviews.freebsd.org/differential/diff/52600/ — it starts up, but

  • input devices aren't attached — I'm not seeing anywhere in the code where it would enumerate subsystem=input, how does KDE attach input devices?! o_0
  • doesn't like my GPU — after starting, there's the splash screen, then black screen for a long time (and amdgpu spam in dmesg), but after a couple minutes the lockscreen appeared! :)

@greg_unrelenting.technology : https://phabricator.kde.org/D18009

deviceFromSyspath("/dev/dri/card0") is actually not necessary anymore! card enumeration seems to work fine since https://github.com/FreeBSDDesktop/libudev-devd/commit/f11ee5b418c740ba6fd4c946ab10b0d89702e4d0

Sorry for being so timeouty on this. @greg_unrelenting.technology , could you rebase the review to the current tree, so we can proceed with it?

val_packett.cool edited the summary of this revision. (Show Details)
val_packett.cool edited the test plan for this revision. (Show Details)

Sure. I've actually made a couple more changes recently btw. I hope PATCH_SITES is okay here

What's blocking this? ck-launch-session sway works fine here after building x11-toolkits/wlroots with CONSOLEKIT=on and x11-wm/sway with SUID=off.

Ping! Now that xorg-server defaults to evdev (for FreeBSD 12.0+) this maybe useful even outside of Wayland.

With my hastily created ad-interim-gnome@-hat this looks good to me, I would like to have some feedback from @manu

Oh, I don't even need to put on a fake hat, desktop@ already took it...

@jbeich were the patches ever upstreamed, or are they just in the fork?

Nowadays x11-toolkits/wlroots supports LIBSEAT in addition to CONSOLEKIT but I don't think Greg has abandoned CONSOLEKIT yet.
https://github.com/DankBSD/build/blob/1fc65d1ac316a5f41982a3961db79cf62011ec70/make.conf#L42

@jbeich were the patches ever upstreamed, or are they just in the fork?

Let me quote:

In D18754#400150, @greg_unrelenting.technology wrote:

Submitted upstream, but the project isn't very active, there are three open PRs and they got no response

Yeah, CK2 has been abandoned for quite some time.

I'll look into seatd and/or other solutions (writing a logind in rust? hehehe), sure. But as long as we do have CK2 in ports, I think it kinda makes sense to make it more fully functional. Even if we abandon my wlroots patch, another interesting consumer is KDE KWin. Last time I touched it, I was able to get to a splash/lock screen..

But as long as we do have CK2 in ports, I think it kinda makes sense to make it more fully functional

Yeah, I agree.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 7:19 PM
This revision was automatically updated to reflect the committed changes.