Page MenuHomeFreeBSD
Differential D18733

nvdimm: initialize SPA uuids statically
ClosedPublic
Actions

Authored by scottph on Jan 3 2019, 8:08 PM.
Tags
None
Referenced Files
F82030164: D18733.id52938.diff
Wed, Apr 24, 6:37 PM
F81979671: D18733.id.diff
Wed, Apr 24, 1:47 AM
Unknown Object (File)
Tue, Apr 23, 6:18 PM
Unknown Object (File)
Sun, Apr 21, 2:06 PM
Unknown Object (File)
Sun, Apr 21, 2:06 PM
Unknown Object (File)
Sun, Apr 21, 2:06 PM
Unknown Object (File)
Sun, Apr 21, 2:06 PM
Unknown Object (File)
Fri, Apr 19, 11:42 PM
View All 57 Files
Subscribers
bwidawsk
emaste
imp

Details

Reviewers
kib
Commits
rS343144: nvdimm: initialize SPA uuids statically.
Summary

The SPA ids are published numbers, so it's safe (if not a bit
annoying) to copy them into a source file.

Submitted by: D Scott Phillips <d.scott.phillips@intel.com>
Sponsored by: Intel Corporation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

scottph created this revision.Jan 3 2019, 8:08 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2019, 8:08 PM
scottph added a parent revision: D18346: nvdimm: add a driver for the NVDIMM root device.Jan 3 2019, 8:15 PM
scottph added a child revision: D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
kib accepted this revision.Jan 15 2019, 5:59 AM

Main reason why I did the initialization that way was to reuse Intel-provided definitions for GUIDs from ACPICA.

This revision is now accepted and ready to land.Jan 15 2019, 5:59 AM
scottph updated this revision to Diff 52938.Jan 17 2019, 6:27 PM
scottph edited the summary of this revision. (Show Details)

Add Intel copyright, add commit message tags.

This revision now requires review to proceed.Jan 17 2019, 6:27 PM
kib accepted this revision.Jan 18 2019, 10:50 AM
This revision is now accepted and ready to land.Jan 18 2019, 10:50 AM
Closed by commit rS343144: nvdimm: initialize SPA uuids statically. (authored by kib). · Explain WhyJan 18 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvdimm/
84 lines
2 lines

Diff 52521

View Options

sys/dev/nvdimm/nvdimm_spa.c

Loading...
View Options

sys/dev/nvdimm/nvdimm_var.h

Loading...