Page MenuHomeFreeBSD

New port: sysutils/intel-undervolt: Intel CPU undervolting tool
AcceptedPublic

Authored by greg_unrelenting.technology on Thu, Jan 3, 6:39 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

arrowd added a subscriber: arrowd.Fri, Jan 4, 3:33 PM
arrowd added inline comments.
sysutils/intel-undervolt/Makefile
6

Aren't you reimplementing GH_TAGNAME with this?

0mp added a subscriber: 0mp.Fri, Jan 4, 3:55 PM
0mp added inline comments.
sysutils/intel-undervolt/Makefile
6

I think this is fine, see Example 5.14. Using USE_GITHUB to Access a Commit Between Two Versions in the Porter's Handbook.

24

I think that we should use @sample here (see 8.6.9. @sample file [file] in the Porter's Handbook).

sysutils/intel-undervolt/Makefile
6

Yeah, I always thought of DISTVERSIONSUFFIX=-gWHATEVER as a "higher level" wrapper around GH_TAGNAME

24

Do the @ things work with PLIST_FILES (w/o dedicated pkg-plist file)?

0mp added inline comments.Wed, Jan 9, 10:22 AM
sysutils/intel-undervolt/Makefile
24

AFAIR, yes.

tobik added a subscriber: tobik.Wed, Jan 9, 10:33 AM
tobik added inline comments.
sysutils/intel-undervolt/Makefile
21

Why +=?

24

Yes, of course. PLIST_FILES is basically just appended to TMPPLIST. Just make sure to quote the entry like "@sample etc/intel-undervolt.conf.sample", so that make(1) treats it as a single word and it's added as one line to it.

Updated with suggestions

greg_unrelenting.technology marked 6 inline comments as done.Wed, Jan 9, 7:34 PM
linimon retitled this revision from New port: sysutils/intel-undervolt to New port: sysutils/intel-undervolt: Intel CPU undervolting tool.Tue, Jan 15, 4:23 PM
tobik accepted this revision.Sun, Jan 20, 1:38 PM

This looks ok.

This revision is now accepted and ready to land.Sun, Jan 20, 1:38 PM