rtld-elf/i386: silence gcc warnings
AbandonedPublic
Actions

Authored by rlibby on Dec 13 2018, 7:13 AM.

Details

Reviewers

arichardson
kib
cem

Summary

r340842 reprise, for i386 this time. The WARNS level was raised
recently. Unfortunately gcc 6.5 is not able to track whether some
variables are initialized across a series of switch statements in
reloc_non_plt and issues false positive warnings.

Test Plan

make CROSS_TOOLCHAIN=amd64-gcc TARGET=amd64 buildworld

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21553
Build 20859: arc lint + arc unit

Event Timeline

rlibby created this revision.Dec 13 2018, 7:13 AM

Harbormaster completed remote builds in B21534: Diff 51950.Dec 13 2018, 7:13 AM

@cem pointed out to me r340842 & r340843. @kib would you prefer we just
did the same to i386 as was done to amd64?

In D18538#395222, @rlibby wrote:

@cem pointed out to me r340842 & r340843. @kib would you prefer we just
did the same to i386 as was done to amd64?

Sure, I do not see why i386 should be different. Put it other way, my opinion is that it is more useful to keep the warning enabled.

Silence warnings in code instead of disabling the warning.

rlibby retitled this revision from rtld-elf: -Wno-error=maybe-uninitialized for gcc to rtld-elf/i386: silence gcc warnings.Dec 13 2018, 10:42 PM

rlibby edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B21553: Diff 51979.Dec 13 2018, 10:42 PM

Might as well apply a similar fix to aarch64/reloc.c, which does something sort of similar (symval). Other archs look different enough not to produce the same warning. (aarch64's use may be simpler enough that the warning is not produced, either, but I have not tried it.)

This revision is now accepted and ready to land.Dec 13 2018, 11:02 PM

kib accepted this revision.Dec 13 2018, 11:07 PM