Page MenuHomeFreeBSD

Allow CTL device specification in bhyve virtio-scsi
ClosedPublic

Authored by mav on Dec 10 2018, 9:51 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Nov 22, 4:24 PM
Unknown Object (File)
Mon, Nov 18, 10:03 PM
Unknown Object (File)
Sep 10 2024, 5:02 PM
Unknown Object (File)
Sep 8 2024, 3:23 PM
Unknown Object (File)
Sep 8 2024, 2:40 AM
Unknown Object (File)
Sep 7 2024, 12:42 PM
Unknown Object (File)
Aug 31 2024, 2:24 AM
Unknown Object (File)
Aug 23 2024, 9:16 PM
Subscribers

Details

Summary

There was a large refactoring done in CTL to allow multiple ioctl frontend ports (and respective devices) to be created, particularly for bhyve. Unfortunately, respective part of bhyve functionality got lost somehow from the original virtio-scsi commit. This change allows wanted device path to be specified in either of two ways:
-s 6,virtio-scsi,/dev/cam/ctl1.1
-s 6,virtio-scsi,dev=/dev/cam/ctl2.3
If neither is specified, the default /dev/cam/ctl device is used.

While there, remove per-queue CTL device opening, which IMO makes no sense at this point.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 21484

Event Timeline

LGTM! Thanks for the patch!

usr.sbin/bhyve/pci_virtio_scsi.c
674

You could declare 'int optidx = 0;' and avoid this extra line here!

This revision is now accepted and ready to land.Dec 11 2018, 5:05 AM
This revision was automatically updated to reflect the committed changes.