Differential D18301

Plug networking sysctl leaks.
ClosedPublic
Actions

Authored by markj on Nov 22 2018, 8:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 9, 7:09 PM

	Unknown Object (File)
	Tue, Jun 9, 6:42 AM

	Unknown Object (File)
	Mon, Jun 8, 10:50 AM

	Unknown Object (File)
	Apr 24 2026, 6:58 PM

	Unknown Object (File)
	Apr 24 2026, 12:08 AM

	Unknown Object (File)
	Apr 20 2026, 6:42 PM

	Unknown Object (File)
	Apr 16 2026, 12:28 PM

	Unknown Object (File)
	Apr 11 2026, 6:35 PM

Subscribers

Details

Reviewers

emaste
brooks
tuexen

Group Reviewers

Commits

rS340783: Plug some networking sysctl leaks.

Summary

Various networking sysctls don't zero-fill their output and thus leak
padding bytes, mostly from the stack. Based on a report I audited a
number of sysctl handlers, especially those which export pcblists, and
fixed a number of leaks, some of which are quite large.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 22 2018, 8:04 PM

Herald added a reviewer: transport. · View Herald TranscriptNov 22 2018, 8:04 PM

Herald added a subscriber: ae. · View Herald Transcript

Harbormaster completed remote builds in B21167: Diff 50929.Nov 22 2018, 8:04 PM

markj added reviewers: emaste, brooks, tuexen.Nov 22 2018, 8:06 PM

tuexen accepted this revision.Nov 22 2018, 8:08 PM

This revision is now accepted and ready to land.Nov 22 2018, 8:08 PM

Closed by commit rS340783: Plug some networking sysctl leaks. (authored by markj). · Explain WhyNov 22 2018, 8:49 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 22 2018, 8:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

3 lines

2 lines

netinet/

3 lines

1 line

1 line

3 lines

5 lines

1 line

netinet6/

3 lines

ofed/

drivers/

infiniband/

ulp/

sdp/

1 line

Diff 50936

head/sys/kern/uipc_socket.c

Loading...

head/sys/kern/uipc_usrreq.c

Loading...

head/sys/netinet/in_pcb.c

Loading...

head/sys/netinet/ip_divert.c

Loading...

head/sys/netinet/raw_ip.c

Loading...

head/sys/netinet/sctp_sysctl.c

Loading...

head/sys/netinet/tcp_subr.c

Loading...

head/sys/netinet/udp_usrreq.c

Loading...

head/sys/netinet6/ip6_mroute.c

Loading...

head/sys/ofed/drivers/infiniband/ulp/sdp/sdp_main.c

Loading...