Details
- portlint
- poudriere testport
- amd64:
- 12.0-RC1
- 11.2
- amd64:
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
@0mp: sorry for all the errors still in portlint, I was running it without any options and thinking I would see everything important. I've fixed the man pages path. There were warnings about the other documentation files too in the older patch, but those got moved out of pmdk in the 1.5 version. The 1.5 version also added a strangely packaged python module which I've left out of the port altogether for the time being.
Cool! Thank a lot!
BTW, you may use arcanist to upload patches to Phabricator. It makes it much easier to work on them later on (otherwise patches miss important steps like creating new directories, from time to time).
- Hook to the build in devel/Makefile.
- Remove pmreorder in post-stage.
- Fix typos in pkg-descr.
I wasn't able to upload this using arcanist due to some errors (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233223).
Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
| devel/pmdk/Makefile | ||
|---|---|---|
| 17–18 ↗ | (On Diff #50890) | Wrong order. See Chapter 15. Order of Variables in Port Makefiles. |
| 21–22 ↗ | (On Diff #50890) | downcase values. |
| 28 ↗ | (On Diff #50890) | post-install. |
I'd love to but Arcanist throws errors at me for some reason :/ (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233223)
I forgot about -U9999. I'll update the diff and adress your commentss soon. :)
Thanks, Mat!
| devel/pmdk/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #50997) | doxygen should always be guarded by a DOXYGEN option so that people who do not want the documentation do not have to install all of that. |
| devel/pmdk/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #50997) | This latest update seems to have moved back to the 1.4.2 version of pmdk. |
Thanks!
I've been testing the build in Poudriere today. It seems to build just fine without Doxygen.
I'm testing a build with Doxygen now so that the documentation could be installed. (BTW, is there a reason why the documentation wasn't installed in the first patch, @scott.d.phillips_intel.com? Let me know what you think about adding an option to install additional documentation).
@mat, I believe that this revision is ready to be committed.
The whole Doxygen and Pandoc thing could be dropped all together. We may add them later if @scott.d.phillips_intel.com decides it is useful.
With the pmdk 1.5 release, all the Doxygen content was moved to a separate project, libpmemobj-cpp. I'll be sure to have a DOCS option when I port that package.