Page MenuHomeFreeBSD

Use tcp_state_change() in the cxgbe(4) TOE module.
ClosedPublic

Authored by jhb on Nov 9 2018, 12:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 20, 12:03 AM
Unknown Object (File)
Wed, Jul 8, 9:07 PM
Unknown Object (File)
Wed, Jul 8, 12:53 PM
Unknown Object (File)
Tue, Jul 7, 7:17 AM
Unknown Object (File)
Mon, Jul 6, 4:57 AM
Unknown Object (File)
May 15 2026, 4:03 AM
Unknown Object (File)
Apr 27 2026, 5:54 AM
Unknown Object (File)
Apr 26 2026, 9:13 AM
Subscribers

Details

Summary

r254889 added tcp_state_change() as a centralized place to log state
changes in TCP connections for DTrace. r294869 and r296881 took
advantage of this central location to manage per-state counters.
However, TOE sockets were still performing some (but not all) state
change updates via direct assignments to t_state. This resulted in
state counters underflowing when TOE was in use. Fix by using
tcp_state_change() when changing a TOE connection's state.

Test Plan
  • run netstat -s -p tcp while TOE is in use

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable