Page MenuHomeFreeBSD

Use tcp_state_change() in the cxgbe(4) TOE module.
ClosedPublic

Authored by jhb on Nov 9 2018, 12:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 8:01 PM
Unknown Object (File)
Sep 11 2025, 9:27 AM
Unknown Object (File)
Sep 11 2025, 4:15 AM
Unknown Object (File)
Sep 10 2025, 2:11 AM
Unknown Object (File)
Aug 13 2025, 9:41 AM
Unknown Object (File)
Aug 2 2025, 4:24 AM
Unknown Object (File)
Jul 16 2025, 1:42 AM
Unknown Object (File)
Jun 16 2025, 6:15 PM
Subscribers

Details

Summary

r254889 added tcp_state_change() as a centralized place to log state
changes in TCP connections for DTrace. r294869 and r296881 took
advantage of this central location to manage per-state counters.
However, TOE sockets were still performing some (but not all) state
change updates via direct assignments to t_state. This resulted in
state counters underflowing when TOE was in use. Fix by using
tcp_state_change() when changing a TOE connection's state.

Test Plan
  • run netstat -s -p tcp while TOE is in use

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable