Enable use of a global shared page for RISC-V.
ClosedPublic
Actions

Authored by jhb on Nov 6 2018, 9:09 PM.

Details

Reviewers

br
kib
markj

Commits

rS354260: MFC r340228-r340229, r340231
rS340228: Enable use of a global shared page for RISC-V.

Summary

machine/vmparam.h already defines the SHAREDPAGE constant. This
change just enables it for ELF executables. The only use of the shared
page currently is to hold the signal trampoline.

Test Plan

ran my 'sigframe' test program which raises nested signals that I use to test signal frame unwinding under gdb under gdb and verified the signal trampoline was executing out of the shared page rather than the stack.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20666
Build 20081: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 6 2018, 9:09 PM

Harbormaster completed remote builds in B20666: Diff 50084.Nov 6 2018, 9:09 PM

markj accepted this revision.Nov 6 2018, 9:14 PM

markj added inline comments.

sys/riscv/riscv/elf_machdep.c
114	Copy-pasted from arm64, it seems. Looks like we should delete both definitions.

This revision is now accepted and ready to land.Nov 6 2018, 9:14 PM

jhb marked an inline comment as done.Nov 6 2018, 9:15 PM

jhb added inline comments.

sys/riscv/riscv/elf_machdep.c
114	This is a separate question that won't be committed. However, I think we should just be able to delete this extra brand info? It also doesn't belong in arm64.