Page MenuHomeFreeBSD
Differential D17805

Make vop_symlink take a const target path.
ClosedPublic
Actions

Authored by brooks on Nov 1 2018, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 11:58 AM
Unknown Object (File)
Mon, Nov 18, 12:21 PM
Unknown Object (File)
Sun, Nov 17, 5:02 AM
Unknown Object (File)
Mon, Nov 4, 9:58 AM
Unknown Object (File)
Wed, Oct 30, 7:35 PM
Unknown Object (File)
Mon, Oct 28, 11:31 PM
Unknown Object (File)
Oct 26 2024, 8:17 AM
Unknown Object (File)
Oct 21 2024, 11:01 AM
View All 74 Files
Subscribers
delphij
imp

Details

Reviewers
kib
jhb
Group Reviewers
manpages
Commits
rD52461: Document __FreeBSD_version 1300003: vop_symlink API change.
rS340055: Make vop_symlink take a const target path.
Summary

This will enable callers to take const paths as part of syscall
decleration improvements.

Where doing so is easy and non-distruptive carry the const through
implementations. In UFS the value is passed to an interface that must
take non-const values. In ZFS, const poisoning would touch code shared
with upstream and it's not worth adding diffs.

Test Plan

tinderbox build, build kmod ports

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Nov 1 2018, 4:27 PM
Herald added a subscriber: delphij. · View Herald TranscriptNov 1 2018, 4:27 PM
Harbormaster completed remote builds in B20577: Diff 49890.Nov 1 2018, 4:27 PM
kib accepted this revision.Nov 1 2018, 5:49 PM
This revision is now accepted and ready to land.Nov 1 2018, 5:49 PM
brooks updated this revision to Diff 49904.Nov 1 2018, 10:05 PM
  • Update the VOP_SYMLINK signature in the manpage.
This revision now requires review to proceed.Nov 1 2018, 10:05 PM
Harbormaster completed remote builds in B20586: Diff 49904.Nov 1 2018, 10:05 PM
brooks updated this revision to Diff 49915.Nov 1 2018, 11:19 PM
  • Add missed __DECONST in nandfs.
Harbormaster completed remote builds in B20588: Diff 49915.Nov 1 2018, 11:19 PM
brooks added a child revision: D17812: Add const to input-only char * arguments..Nov 1 2018, 11:39 PM
brooks updated this revision to Diff 49918.Nov 1 2018, 11:49 PM
  • Rebase
  • Bump __FreeBSD_version for external API consumers.
Harbormaster completed remote builds in B20590: Diff 49918.Nov 1 2018, 11:49 PM
brooks added a comment.Nov 1 2018, 11:55 PM

With the nandfs fix this passes universe. I've done a search for vop_symlink on https://grok.dragonflybsd.org and concluded that an exp-run isn't going to find anything so I'll skip that.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2018, 2:43 PM
Closed by commit rS340055: Make vop_symlink take a const target path. (authored by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptNov 2 2018, 2:43 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
head/
share/
man/
man9/
4 lines
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
2 lines
fs/
ext2fs/
4 lines
fuse/
2 lines
nandfs/
4 lines
nfs/
2 lines
nfsclient/
2 lines
tmpfs/
4 lines
4 lines
2 lines
kern/
2 lines
sys/
2 lines
ufs/
ufs/
6 lines

Diff 49936

View Options

head/share/man/man9/VOP_CREATE.9

Loading...
View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_vnops.c

Loading...
View Options

head/sys/fs/fuse/fuse_vnops.c

Loading...
View Options

head/sys/fs/nandfs/nandfs_vnops.c

Loading...
View Options

head/sys/fs/nfs/nfs_var.h

Loading...
View Options

head/sys/fs/nfsclient/nfs_clrpcops.c

Loading...
View Options

head/sys/fs/tmpfs/tmpfs.h

Loading...
View Options

head/sys/fs/tmpfs/tmpfs_subr.c

Loading...
View Options

head/sys/fs/tmpfs/tmpfs_vnops.c

Loading...
View Options

head/sys/kern/vnode_if.src

Loading...
View Options

head/sys/sys/param.h

Loading...
View Options

head/sys/ufs/ufs/ufs_vnops.c

Loading...