Page MenuHomeFreeBSD

emulators/linux-power9-functional-sim: New port
ClosedPublic

Authored by kbowling on Oct 13 2018, 7:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 4:56 AM
Unknown Object (File)
Sat, Apr 20, 1:32 PM
Unknown Object (File)
Fri, Apr 12, 9:46 AM
Unknown Object (File)
Mar 4 2024, 11:01 PM
Unknown Object (File)
Mar 4 2024, 11:01 PM
Unknown Object (File)
Mar 4 2024, 11:01 PM
Unknown Object (File)
Mar 4 2024, 10:57 PM
Unknown Object (File)
Mar 4 2024, 10:45 PM

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emulators/linux-power9-functional-sim/Makefile
18–21 ↗(On Diff #49088)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

krion requested changes to this revision.Oct 18 2018, 8:03 AM
krion added inline comments.
emulators/linux-power9-functional-sim/Makefile
22 ↗(On Diff #49122)

Yeah, vars here are out of order

This revision now requires changes to proceed.Oct 18 2018, 8:03 AM
kbowling added inline comments.
emulators/linux-power9-functional-sim/Makefile
22 ↗(On Diff #49122)

Please explain how to fix, the only thing I took away from the initial comment was block organization

kbowling added inline comments.
emulators/linux-power9-functional-sim/Makefile
22 ↗(On Diff #49122)

I also don't see any issue now, but as it's not the first time ordering question arise - do you run portlint when preparing (new) ports? If so, can you, please, also provide it's output?

kev-ws-aurora% portlint -A
WARN: /usr/home/kev009/c/fbsd-rw/ports-head/emulators/linux-power9-functional-sim/pkg-descr: includes lines that exceed 80 characters.
0 fatal errors and 1 warning found.

krion added inline comments.
emulators/linux-power9-functional-sim/Makefile
22 ↗(On Diff #49122)

Sorry my fault

This revision is now accepted and ready to land.Oct 22 2018, 6:49 AM
This revision was automatically updated to reflect the committed changes.