Page MenuHomeFreeBSD

Add stat counter for ipv6 atomic fragments
ClosedPublic

Authored by thj on Oct 10 2018, 8:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 27 2024, 5:09 AM
Unknown Object (File)
Jan 27 2024, 5:09 AM
Unknown Object (File)
Jan 27 2024, 5:09 AM
Unknown Object (File)
Jan 26 2024, 5:33 AM
Unknown Object (File)
Dec 22 2023, 11:16 PM
Unknown Object (File)
Dec 10 2023, 6:06 PM
Unknown Object (File)
Nov 29 2023, 1:59 AM
Unknown Object (File)
Nov 29 2023, 12:03 AM
Subscribers

Details

Summary

Add stat counter for ipv6 atomic fragments.

Add support for atomic frag counter in systat

Add support for atomic frag counter in netstat

Test Plan

There is a scapy test program here that generates UDP atomic fragments:
https://people.freebsd.org/~thj/tests/atomicfrag.py

Run test program against host and examine counter, atomic frags are now exposed
in patched netstat and patch systat.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 10 2018, 8:28 PM
bz added a subscriber: bz.
bz added inline comments.
sys/netinet6/frag6.c
282 ↗(On Diff #48988)

The reference should probably include RFC 8200 4.5. as well now as it has incorporated this case.

sys/netinet6/ip6_var.h
211 ↗(On Diff #48988)

If you want to merge this possibly at any time, make sure to put the value at the end (in the MFC) and not into the middle shifting all offsets around and breaking already existing applications.

Please make the two changes suggested by bz@ and then feel free to commit this. I think its OK to ask re@ to commit this during the freeze. (I also won't be upset if they say "no".)

Note that it is worth adding a sentence to your commit message explaining "why" we want this separate counter.

This revision was automatically updated to reflect the committed changes.