Page MenuHomeFreeBSD

Fix net/qt4-network with OpenSSL 1.1.1

Authored by adridg on Oct 8 2018, 1:33 PM.
Referenced Files
Unknown Object (File)
Fri, Sep 22, 9:23 PM
Unknown Object (File)
Sat, Sep 16, 6:47 AM
Unknown Object (File)
Mon, Aug 28, 11:39 AM
Unknown Object (File)
Aug 7 2023, 6:43 PM
Unknown Object (File)
Aug 2 2023, 8:54 PM
Unknown Object (File)
Jul 16 2023, 3:48 AM
Unknown Object (File)
Jul 2 2023, 1:16 PM
Unknown Object (File)
Jul 1 2023, 1:14 AM



Took original patch, added DEFINEFUNC and RESOLVEFUNC from
Arch patches, then fixed for use of get0.

Test Plan
  • build and run quiterss
  • build and run smtube

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

13 ↗(On Diff #48893)

Should ithe X509_get_serialNumber lines be under OPENSSL_VERSION_NUMBER higher than 0x101..?

adridg added inline comments.
13 ↗(On Diff #48893)

No. The Arch patch adds this outside of the #if as well, and the function is present in OpenSSL 1.0.2 already. It might be a spurious addition, but here I'd prefer to just follow along.

linimon retitled this revision from Fix qt4-network with OpenSSL 1.1.1 to Fix net/qt4-network with OpenSSL 1.1.1.Oct 9 2018, 2:53 PM
linimon added a subscriber: linimon.
6 ↗(On Diff #48893)

No need to bump, it was not building before.

6 ↗(On Diff #48893)

The binaries change, it needs a bump.

sbruno added a subscriber: sbruno.

This allows audio/murmur to build again.

This revision is now accepted and ready to land.Oct 18 2018, 1:50 PM

Note, though, that "ports dependent on qt4-network build" and "ports dependent on qt4-network actually do anything useful in the face of an SSL connection" are two different things. I could land this to get things to build again, but I'm fairly certain it doesn't do the right thing. At least, I couldn't get .. um whatever two ports I tried which use qt4-network .. to work (quterss? smtube? maybe those two). However, I can't tell the difference between "doesn't work because of SSL" and "doesn't work because of something else", since I've never used either of those before.

I'll test this against clementine-player today and see if it can do SSL/TLS connections for streaming. That should give us a bit of a warm fuzzy.

des added inline comments.
41–63 ↗(On Diff #48893)

This can be simplified by defining keyType in both cases, with a different initial value (but why on Earth did they not use a switch?)

This definitely fixes the build and runtime of clementine-player (qt4).

It looks like the fetching of album covers and such stopped working though. Which appears to be via https. I suspect there are some tweaks still to be made in here.

This revision was automatically updated to reflect the committed changes.