Page MenuHomeFreeBSD
Differential D17308

net80211: Enable netdump support
ClosedPublic
Actions

Authored by cem on Sep 24 2018, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 9:34 AM
Unknown Object (File)
Tue, Nov 5, 12:26 AM
Unknown Object (File)
Mon, Nov 4, 10:13 AM
Unknown Object (File)
Oct 11 2024, 4:57 PM
Unknown Object (File)
Oct 9 2024, 12:03 AM
Unknown Object (File)
Oct 3 2024, 4:14 PM
Unknown Object (File)
Sep 28 2024, 1:03 AM
Unknown Object (File)
Sep 24 2024, 3:53 AM
View All 72 Files
Subscribers
imp
melifaro

Details

Reviewers
markj
adrian
Commits
rS362138: net80211: Add framework for debugnet(4) support
Summary

Allow net80211 drivers to register a small vtable of netdump-related
methods.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20675
Build 20090: arc lint + arc unit

Event Timeline

cem created this revision.Sep 24 2018, 11:46 PM
Harbormaster completed remote builds in B19786: Diff 48416.Sep 24 2018, 11:46 PM
adrian added inline comments.Sep 25 2018, 12:04 AM
sys/net80211/ieee80211.c
710 ↗(On Diff #48416)

Hi!

This stuff should go into the freebsd specific header file, as other OSes are using this wifi stack now!

cem marked an inline comment as done.Sep 25 2018, 12:18 AM
cem added inline comments.
sys/net80211/ieee80211.c
710 ↗(On Diff #48416)

Hi Adrian,

How would I hook vap_attach from the freebsd header? Thanks!

(The stuff below can move, no problem.)

adrian added inline comments.Sep 25 2018, 12:22 AM
sys/net80211/ieee80211.c
710 ↗(On Diff #48416)

Create a separate function, say ieee80211_netdump_attach(), and then the non-freebsd OSes can stub it out.

cem marked an inline comment as done and an inline comment as not done.Sep 25 2018, 12:22 AM
cem added inline comments.
sys/net80211/ieee80211.c
710 ↗(On Diff #48416)

I guess I could hang something off of ieee80211_sysctl_vattach but that seems kind of ugly.

cem marked an inline comment as done.Sep 25 2018, 12:22 AM
cem added inline comments.
sys/net80211/ieee80211.c
710 ↗(On Diff #48416)

Can do, thanks

cem updated this revision to Diff 48417.Sep 25 2018, 12:46 AM

Move netdump attach logic to freebsd-specific net80211 files

Harbormaster completed remote builds in B19787: Diff 48417.Sep 25 2018, 12:46 AM
markj accepted this revision.Sep 25 2018, 1:35 AM
markj added inline comments.
sys/net80211/ieee80211_var.h
376

I strongly prefer to avoid the ifdef here: the bloat is not significant, and it ensures that KLDs have the same view of the struct layout. I think it's not uncommon for people to compile wifi drivers out-of-tree.

This revision is now accepted and ready to land.Sep 25 2018, 1:35 AM
cem marked an inline comment as done.Sep 25 2018, 1:39 AM
cem added inline comments.
sys/net80211/ieee80211_var.h
376

Yeah, I agree. Will fix.

adrian added a comment.Sep 25 2018, 1:43 AM

Yeah please don't ifdef the structure definitions. I need to go do a pass at some point to make that not be a problem; it's 2018 :)

cem updated this revision to Diff 48419.Sep 25 2018, 1:46 AM
cem marked an inline comment as done.

Remove gratuitous ABI difference ifdef NETDUMP

This revision now requires review to proceed.Sep 25 2018, 1:46 AM
Harbormaster completed remote builds in B19789: Diff 48419.Sep 25 2018, 1:46 AM
cem added a comment.Sep 25 2018, 1:53 AM
In D17308#369018, @adrian wrote:

Yeah please don't ifdef the structure definitions. I need to go do a pass at some point to make that not be a problem; it's 2018 :)

Are you ok with #if FreeBSD or do you think we should leave the field in on other OS as well? I don't have any preference. Thanks!

markj added a comment.Sep 25 2018, 1:57 AM
In D17308#369025, @cem wrote:
In D17308#369018, @adrian wrote:

Yeah please don't ifdef the structure definitions. I need to go do a pass at some point to make that not be a problem; it's 2018 :)

Are you ok with #if FreeBSD or do you think we should leave the field in on other OS as well? I don't have any preference. Thanks!

Since you can get away with a forward declaration of the struct, I can't imagine that the field would cause problems on other OS'.

cem added a comment.Sep 25 2018, 2:00 AM
In D17308#369026, @markj wrote:

Since you can get away with a forward declaration of the struct, I can't imagine that the field would cause problems on other OS'.

Sure, just struct bloat there.

cem updated this revision to Diff 50106.Nov 7 2018, 7:47 AM

De-conditionalize 80211dump vtable pointer on FreeBSD per markj.

Harbormaster completed remote builds in B20675: Diff 50106.Nov 7 2018, 7:47 AM
markj accepted this revision.Nov 7 2018, 9:41 PM
This revision is now accepted and ready to land.Nov 7 2018, 9:41 PM
cem added a comment.Jun 12 2020, 4:14 PM

@adrian , is there any chance I could convince you to take this and run with it? I don't currently have FreeBSD running bare metal on a laptop to test this and commit it, but I would love to see it land eventually.

Herald added a subscriber: melifaro. · View Herald TranscriptJun 12 2020, 4:14 PM
adrian added a comment.Jun 12 2020, 7:40 PM

looks fine to me, other OSes won't use it but it won't matter. Land it!

cem added a comment.Jun 12 2020, 7:58 PM

Ok, cool

Closed by commit rS362138: net80211: Add framework for debugnet(4) support (authored by cem). · Explain WhyJun 13 2020, 12:59 AM
This revision was automatically updated to reflect the committed changes.
cem added a commit: rS362138: net80211: Add framework for debugnet(4) support.
Herald added a subscriber: imp. · View Herald TranscriptJun 13 2020, 12:59 AM

Revision Contents
Changeset List

PathSize
sys/
net80211/
34 lines
58 lines
3 lines

Diff 50106

View Options

sys/net80211/ieee80211_freebsd.h

Loading...
View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/net80211/ieee80211_var.h

Loading...