Hold a write lock across udp_notify()
ClosedPublic
Actions

Authored by rstone on Sep 19 2018, 5:08 PM.

Tags

None

Referenced Files

	F151701317: D17246.diff
	Fri, Apr 10, 3:13 AM

	F151689053: D17246.diff
	Fri, Apr 10, 1:03 AM

	Unknown Object (File)
	Fri, Apr 3, 6:00 PM

	Unknown Object (File)
	Fri, Apr 3, 4:02 PM

	Unknown Object (File)
	Fri, Apr 3, 2:28 PM

	Unknown Object (File)
	Thu, Apr 2, 11:56 PM

	Unknown Object (File)
	Thu, Apr 2, 3:40 PM

	Unknown Object (File)
	Thu, Apr 2, 12:48 PM

Subscribers

Details

Reviewers

bz
sbruno
vangyzen

Group Reviewers

transport

Commits

rS339185: Hold a write lock across udp_notify()

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rstone created this revision.Sep 19 2018, 5:08 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 19 2018, 5:08 PM

Harbormaster completed remote builds in B19679: Diff 48227.Sep 19 2018, 5:08 PM

I was wondering for a second about the v6 path; at first glance it seems that udp6_common_ctlinput() via in6_pcbnotify() calls it with a write lock held; wouldn't hurt to double check that please?

LGTM

This revision is now accepted and ready to land.Sep 21 2018, 10:58 PM

LGTM also

Ok, whom would like to submit this to re@ to get it into the tree?

vangyzen accepted this revision.Oct 4 2018, 8:33 PM

Closed by commit rS339185: Hold a write lock across udp_notify() (authored by rstone). · Explain WhyOct 4 2018, 10:04 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 4 2018, 10:04 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

udp_usrreq.c

14 lines

Diff 48757

View Options

head/sys/netinet/udp_usrreq.c

Hold a write lock across udp_notify()ClosedPublicActions