Fix the nvpair leak in vdev_geom_read_config().
ClosedPublic
Actions

Authored by markj on Sep 17 2018, 3:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 5:52 AM

	Unknown Object (File)
	Mon, Nov 18, 8:36 PM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Oct 10 2024, 12:09 AM

	Unknown Object (File)
	Oct 10 2024, 12:09 AM

	Unknown Object (File)
	Oct 10 2024, 12:09 AM

	Unknown Object (File)
	Oct 9 2024, 11:37 PM

	Unknown Object (File)
	Sep 17 2024, 3:21 PM

Subscribers

Details

Reviewers

allanjude
delphij
asomers
avg

Commits

rS338724: Fix an nvpair leak in vdev_geom_read_config().

Summary

Also change the behaviour slightly: instead of freeing "config" if the
last nvlist doesn't pass the tests, return the last config that did pass
those tests. This matches the comment at the beginning of the function.

Test Plan

See PR 230704.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 17 2018, 3:44 PM

Herald added subscribers: asomers, delphij. · View Herald TranscriptSep 17 2018, 3:44 PM

Harbormaster completed remote builds in B19623: Diff 48119.Sep 17 2018, 3:44 PM

markj edited the test plan for this revision. (Show Details)Sep 17 2018, 3:45 PM

markj added reviewers: allanjude, delphij, asomers, avg.

Oops, looks like this one's my fault. Thanks for fixing it, Mark!

This revision is now accepted and ready to land.Sep 17 2018, 3:55 PM

LGTM. Thank you!

Closed by commit rS338724: Fix an nvpair leak in vdev_geom_read_config(). (authored by markj). · Explain WhySep 17 2018, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptSep 17 2018, 4:18 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

vdev_geom.c

21 lines

Diff 48125

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c

Fix the nvpair leak in vdev_geom_read_config().ClosedPublicActions