Page MenuHomeFreeBSD
Differential D17192

Handle the vm* instructions from a guest
ClosedPublic
Actions

Authored by andrew on Sep 17 2018, 1:04 PM.
Tags
None
Referenced Files
F168047228: D17192.id48396.diff
Wed, Aug 26, 3:13 AM
F167988902: D17192.id.diff
Tue, Aug 25, 7:04 PM
F167976905: D17192.id48503.diff
Tue, Aug 25, 5:32 PM
F167959418: D17192.id48102.diff
Tue, Aug 25, 3:29 PM
Unknown Object (File)
Tue, Aug 25, 10:58 AM
Unknown Object (File)
Mon, Aug 24, 11:50 AM
Unknown Object (File)
Wed, Aug 12, 5:38 PM
Unknown Object (File)
Tue, Aug 11, 8:00 PM
View All Files
Subscribers
araujo
emaste
imp

Details

Reviewers
jhb
rgrimes
tychon
araujo
Group Reviewers
bhyve
Commits
rS338957: Handle a guest executing a vm instruction by trapping and raising an
Summary

Handle a guest executing a vm instruction by trapping and raising an
undefined instruction exception. Previously we would exit the guest,
however an unprivileged user could execute these.

Found with: syzkaller

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Sep 17 2018, 1:04 PM
Herald added a reviewer: rgrimes. · View Herald TranscriptSep 17 2018, 1:04 PM
Harbormaster completed remote builds in B19619: Diff 48102.Sep 17 2018, 1:04 PM
tychon accepted this revision.Sep 17 2018, 1:35 PM
This revision is now accepted and ready to land.Sep 17 2018, 1:35 PM
araujo accepted this revision.Sep 17 2018, 4:00 PM
araujo added a subscriber: araujo.

Lgtm!

emaste added a subscriber: emaste.Sep 17 2018, 4:38 PM
andrew updated this revision to Diff 48396.Sep 24 2018, 1:38 PM

Add the missing SDT_PROBE_DEFINE3

This revision now requires review to proceed.Sep 24 2018, 1:38 PM
Harbormaster completed remote builds in B19776: Diff 48396.Sep 24 2018, 1:38 PM
araujo accepted this revision.Sep 26 2018, 12:03 AM

Lgtm

This revision is now accepted and ready to land.Sep 26 2018, 12:03 AM
Closed by commit rS338957: Handle a guest executing a vm instruction by trapping and raising an (authored by andrew). · Explain WhySep 27 2018, 11:17 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptSep 27 2018, 11:17 AM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
include/
1 line
vmm/
intel/
16 lines
1 line

Diff 48503

View Options

head/sys/amd64/include/vmm.h

Loading...
View Options

head/sys/amd64/vmm/intel/vmx.c

Loading...
View Options

head/sys/amd64/vmm/vmm.c

Loading...