Page MenuHomeFreeBSD

Fix capabilities handling for iflib drivers
ClosedPublic

Authored by shurd on Sep 13 2018, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 13 2025, 8:53 AM
Unknown Object (File)
Sep 10 2025, 9:06 PM
Unknown Object (File)
Aug 25 2025, 12:24 AM
Unknown Object (File)
Aug 21 2025, 9:44 AM
Unknown Object (File)
Jul 31 2025, 4:41 PM
Unknown Object (File)
Jul 27 2025, 6:10 PM
Unknown Object (File)
Jul 26 2025, 10:45 PM
Unknown Object (File)
Jul 16 2025, 8:57 PM
Subscribers

Details

Summary

Various capabilities were not being handled correctly in the
SIOCSIFCAP handler. Specifically:

IFCAP_RXCSUM and IFCAP_RXCSUM_IPV6 could be set even if not supported

It was impossible to disable IFCAP_RXCSUM and/or IFCAP_RXCSUM_IPV6 via
ifconfig since it does ioctl() per command-line flag rather than combine
them into a single call.

IFCAP_VLAN_HWCSUM could not be modified via the ioctl()

Setting any combination of the three IFCAP_WOL flags would set only
IFCAP_WOL_MCAST | IFCAP_WOL_MAGIC. For example, setting only
IFCAP_WOL_UCAST would result in both IFCAP_WOL_MCAST and IFCAP_WOL_MAGIC
being enabled, bit IFCAP_WOL_UCAST would not be enabled.

Because if_vlancap() was called before if_togglecapenable(), vlan flags
were sometimes not paplied correctly.

Interfaces was being unnecessarily stopped and restarted for WoL
capability changes.

PR: 231151
Submitted by: Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp>

Test Plan

Ensure all ifconfig options are applied correctly.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable