Page MenuHomeFreeBSD

Fix 'install: symlink usr/src/sys -> /sys: File exists' in distributeworld
ClosedPublic

Authored by lwhsu on Aug 23 2018, 11:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 18 2024, 1:34 AM
Unknown Object (File)
Jan 28 2024, 6:30 PM
Unknown Object (File)
Jan 21 2024, 1:23 PM
Unknown Object (File)
Dec 23 2023, 5:30 AM
Unknown Object (File)
Dec 20 2023, 3:00 AM
Unknown Object (File)
Dec 18 2023, 5:50 PM
Unknown Object (File)
Nov 29 2023, 1:56 PM
Unknown Object (File)
Nov 7 2023, 11:11 AM
Subscribers

Details

Summary

Follow r334617, also specify ${DISTDIR} & '/base' while installing '/sys' symbolic link.

Test Plan

cd src && make -DNO_ROOT distributeworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The full correct path also needs '/base'

Add ${INSTALLFLAGS} to provide required arguments for install(1)
Remove slash between ${DESTDIR}/${DISTDIR} to prevent superfluous slash in path

Approved, but I suggest waiting a day for reviewers to respond. I don't understand this area well enough to review it myself.

This revision is now accepted and ready to land.Aug 24 2018, 6:39 AM

The only concern I have here is the use of DISTDIR which is also used in ports to override the location of Distfiles..

In D16877#359737, @brd wrote:

The only concern I have here is the use of DISTDIR which is also used in ports to override the location of Distfiles..

I think this is fine, DISTDIR is used in lots of places in this file.

BTW, after looking this file again, it seems that using INSTALL_DDIR which is defined earlier in this file is the proper way to have sensible ${DESTDIR}/${DISTDIR}. I'll work on a patch to utilize that.

Use ${INSTALL_DDIR} to prevent consecutive slash caused by
${DESTDIR}/${DISTDIR}

This revision now requires review to proceed.Aug 27 2018, 3:10 AM
This revision is now accepted and ready to land.Aug 28 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.