Page MenuHomeFreeBSD

Fix 'install: symlink usr/src/sys -> /sys: File exists' in distributeworld
ClosedPublic

Authored by lwhsu on Aug 23 2018, 11:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 6:11 AM
Unknown Object (File)
Wed, Oct 8, 2:20 AM
Unknown Object (File)
Mon, Oct 6, 3:20 AM
Unknown Object (File)
Sun, Sep 28, 5:25 AM
Unknown Object (File)
Mon, Sep 22, 9:06 PM
Unknown Object (File)
Sat, Sep 20, 3:04 PM
Unknown Object (File)
Aug 26 2025, 9:57 PM
Unknown Object (File)
Aug 26 2025, 2:06 PM
Subscribers

Details

Summary

Follow r334617, also specify ${DISTDIR} & '/base' while installing '/sys' symbolic link.

Test Plan

cd src && make -DNO_ROOT distributeworld

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The full correct path also needs '/base'

Add ${INSTALLFLAGS} to provide required arguments for install(1)
Remove slash between ${DESTDIR}/${DISTDIR} to prevent superfluous slash in path

Approved, but I suggest waiting a day for reviewers to respond. I don't understand this area well enough to review it myself.

This revision is now accepted and ready to land.Aug 24 2018, 6:39 AM

The only concern I have here is the use of DISTDIR which is also used in ports to override the location of Distfiles..

In D16877#359737, @brd wrote:

The only concern I have here is the use of DISTDIR which is also used in ports to override the location of Distfiles..

I think this is fine, DISTDIR is used in lots of places in this file.

BTW, after looking this file again, it seems that using INSTALL_DDIR which is defined earlier in this file is the proper way to have sensible ${DESTDIR}/${DISTDIR}. I'll work on a patch to utilize that.

Use ${INSTALL_DDIR} to prevent consecutive slash caused by
${DESTDIR}/${DISTDIR}

This revision now requires review to proceed.Aug 27 2018, 3:10 AM
This revision is now accepted and ready to land.Aug 28 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.