Follow r334617, also specify ${DISTDIR} & '/base' while installing '/sys' symbolic link.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Add ${INSTALLFLAGS} to provide required arguments for install(1)
Remove slash between ${DESTDIR}/${DISTDIR} to prevent superfluous slash in path
Comment Actions
Approved, but I suggest waiting a day for reviewers to respond. I don't understand this area well enough to review it myself.
Comment Actions
The only concern I have here is the use of DISTDIR which is also used in ports to override the location of Distfiles..
Comment Actions
I think this is fine, DISTDIR is used in lots of places in this file.
BTW, after looking this file again, it seems that using INSTALL_DDIR which is defined earlier in this file is the proper way to have sensible ${DESTDIR}/${DISTDIR}. I'll work on a patch to utilize that.