Fix generation of krb5-config with LC_CTYPE=*.UTF-8
ClosedPublic
Actions

Authored by arichardson on Aug 22 2018, 5:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 19, 6:43 AM

	Unknown Object (File)
	Sat, Apr 18, 4:36 AM

	Unknown Object (File)
	Thu, Apr 16, 10:45 PM

	Unknown Object (File)
	Wed, Apr 15, 11:40 PM

	Unknown Object (File)
	Wed, Apr 15, 2:24 PM

	Unknown Object (File)
	Wed, Apr 15, 6:50 AM

	Unknown Object (File)
	Mon, Apr 6, 7:48 PM

	Unknown Object (File)
	Sun, Apr 5, 7:04 PM

View All Files

Subscribers

None

Details

Reviewers

jhb
emaste
brooks
imp
cy

Commits

rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8

Summary

When building on MacOS with a UTF-8 locale sed will fail when reading
krb-config.in due to invalid characters. Forcing the "C" locale fixes this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Aug 22 2018, 5:01 PM

Harbormaster completed remote builds in B19054: Diff 47111.Aug 22 2018, 5:02 PM

ping?

OK.

(Really, upstream should migrate the file to UTF-8 though.)

This revision is now accepted and ready to land.Feb 27 2019, 2:38 AM

lgtm

Closed by commit rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8 (authored by arichardson). · Explain WhyJul 1 2019, 11:48 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS349576: Fix generation of krb5-config with LC_CTYPE=*.UTF-8.

Revision Contents
Changeset List

Path

Size

head/

kerberos5/

usr.bin/

krb5-config/

Makefile

6 lines

Diff 59254

View Options

head/kerberos5/usr.bin/krb5-config/Makefile

Fix generation of krb5-config with LC_CTYPE=*.UTF-8ClosedPublicActions