Page MenuHomeFreeBSD

Move all devd related configs to sbin/devd/
ClosedPublic

Authored by brd on Aug 18 2018, 9:50 AM.
Tags
None
Referenced Files
F132464800: D16781.id47044.diff
Fri, Oct 17, 3:59 AM
Unknown Object (File)
Tue, Oct 7, 4:39 PM
Unknown Object (File)
Sat, Oct 4, 5:17 AM
Unknown Object (File)
Thu, Oct 2, 3:36 AM
Unknown Object (File)
Thu, Sep 25, 4:04 AM
Unknown Object (File)
Sat, Sep 20, 6:57 AM
Unknown Object (File)
Sep 13 2025, 5:57 PM
Unknown Object (File)
Sep 10 2025, 1:52 AM

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove an extra file that snuck in

etc/Makefile
179 ↗(On Diff #46880)

this whole thing is unrelated.

sbin/devd/Makefile
11 ↗(On Diff #46880)

this is wrong. Extra .if.

However, it's also bogus for devmatch.conf: that should be installed everywhere.

will requested changes to this revision.Aug 18 2018, 9:23 PM
will added inline comments.
etc/Makefile
179 ↗(On Diff #46880)

I agree, this section removal belongs to another commit.

sbin/devd/Makefile
11 ↗(On Diff #46880)

Agree. I'm not seeing the corresponding deletes, so I'm guessing the commit was meant to include a different etc/Makefile.

This revision now requires changes to proceed.Aug 18 2018, 9:23 PM
etc/Makefile
179 ↗(On Diff #46880)

Opps, yeah, I thought my tree was clean, obviously not. Will update.

Update with right etc/Makefile changes

brd marked 3 inline comments as done.Aug 18 2018, 11:15 PM
sbin/devd/Makefile
10 ↗(On Diff #46913)

I think you mean /etc/devd? You've tested this?

Fix a few typos after real testing

brd marked an inline comment as done.Aug 20 2018, 1:58 AM
brd added inline comments.
sbin/devd/Makefile
10 ↗(On Diff #46913)

I have now that I am back and fixed my build box.

brd marked 4 inline comments as done.Aug 20 2018, 3:08 AM
This revision is now accepted and ready to land.Aug 21 2018, 2:06 AM
sbin/devd/Makefile
11 ↗(On Diff #46953)

Do we really need this? HYPERV is only true here. And ACPI is also true on arm64. the asus.conf is valid there IMHO.

24 ↗(On Diff #46953)

It would be better to use MACHINE_CPUARCH here... This is userland, so keying off the kernel arch ($MACHINE) is not right.

This revision now requires review to proceed.Aug 21 2018, 4:07 PM
brd marked 2 inline comments as done.Aug 21 2018, 4:08 PM
This revision is now accepted and ready to land.Aug 21 2018, 4:19 PM
This revision was automatically updated to reflect the committed changes.