Page MenuHomeFreeBSD
Differential D16781

Move all devd related configs to sbin/devd/
ClosedPublic
Actions

Authored by brd on Aug 18 2018, 9:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 2:27 PM
Unknown Object (File)
Thu, Dec 5, 7:07 PM
Unknown Object (File)
Mon, Dec 2, 10:39 PM
Unknown Object (File)
Mon, Dec 2, 5:41 AM
Unknown Object (File)
Sun, Nov 24, 4:54 AM
Unknown Object (File)
Nov 22 2024, 4:05 AM
Unknown Object (File)
Nov 20 2024, 10:09 AM
Unknown Object (File)
Nov 16 2024, 7:07 PM
View All Files
Subscribers
asomers
bdrewery
emaste
imp

Details

Reviewers
will
allanjude
imp
Commits
rS338144: Move all devd related configs to sbin/devd/

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brd created this revision.Aug 18 2018, 9:50 AM
Herald added subscribers: asomers, emaste, imp, bdrewery. · View Herald TranscriptAug 18 2018, 9:50 AM
Harbormaster completed remote builds in B18920: Diff 46878.Aug 18 2018, 9:50 AM
brd updated this revision to Diff 46880.Aug 18 2018, 10:13 AM

Remove an extra file that snuck in

Harbormaster completed remote builds in B18922: Diff 46880.Aug 18 2018, 10:13 AM
imp added inline comments.Aug 18 2018, 2:07 PM
etc/Makefile
179 ↗(On Diff #46880)

this whole thing is unrelated.

sbin/devd/Makefile
11 ↗(On Diff #46880)

this is wrong. Extra .if.

However, it's also bogus for devmatch.conf: that should be installed everywhere.

will requested changes to this revision.Aug 18 2018, 9:23 PM
will added inline comments.
etc/Makefile
179 ↗(On Diff #46880)

I agree, this section removal belongs to another commit.

sbin/devd/Makefile
11 ↗(On Diff #46880)

Agree. I'm not seeing the corresponding deletes, so I'm guessing the commit was meant to include a different etc/Makefile.

This revision now requires changes to proceed.Aug 18 2018, 9:23 PM
brd added inline comments.Aug 18 2018, 11:05 PM
etc/Makefile
179 ↗(On Diff #46880)

Opps, yeah, I thought my tree was clean, obviously not. Will update.

brd updated this revision to Diff 46912.Aug 18 2018, 11:15 PM

Update with right etc/Makefile changes

Harbormaster completed remote builds in B18943: Diff 46912.Aug 18 2018, 11:15 PM
brd marked 3 inline comments as done.Aug 18 2018, 11:15 PM
brd updated this revision to Diff 46913.Aug 18 2018, 11:20 PM

Address @imp feedback

Harbormaster completed remote builds in B18944: Diff 46913.Aug 18 2018, 11:20 PM
will added inline comments.Aug 19 2018, 8:44 AM
sbin/devd/Makefile
10 ↗(On Diff #46913)

I think you mean /etc/devd? You've tested this?

brd updated this revision to Diff 46953.Aug 20 2018, 1:56 AM

Fix a few typos after real testing

Harbormaster completed remote builds in B18961: Diff 46953.Aug 20 2018, 1:56 AM
brd marked an inline comment as done.Aug 20 2018, 1:58 AM
brd added inline comments.
sbin/devd/Makefile
10 ↗(On Diff #46913)

I have now that I am back and fixed my build box.

brd marked 4 inline comments as done.Aug 20 2018, 3:08 AM
brd added a reviewer: imp.Aug 20 2018, 3:28 AM
will accepted this revision.Aug 21 2018, 2:06 AM
This revision is now accepted and ready to land.Aug 21 2018, 2:06 AM
imp added inline comments.Aug 21 2018, 3:27 AM
sbin/devd/Makefile
11 ↗(On Diff #46953)

Do we really need this? HYPERV is only true here. And ACPI is also true on arm64. the asus.conf is valid there IMHO.

24 ↗(On Diff #46953)

It would be better to use MACHINE_CPUARCH here... This is userland, so keying off the kernel arch ($MACHINE) is not right.

brd updated this revision to Diff 47044.Aug 21 2018, 4:07 PM

Address @imp feedback

This revision now requires review to proceed.Aug 21 2018, 4:07 PM
Harbormaster completed remote builds in B19013: Diff 47044.Aug 21 2018, 4:07 PM
brd marked 2 inline comments as done.Aug 21 2018, 4:08 PM
imp accepted this revision.Aug 21 2018, 4:19 PM
This revision is now accepted and ready to land.Aug 21 2018, 4:19 PM
Closed by commit rS338144: Move all devd related configs to sbin/devd/ (authored by brd). · Explain WhyAug 21 2018, 4:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
etc/
2 lines
353 lines
devd/
34 lines
80 lines
74 lines
20 lines
108 lines
146 lines
18 lines
77 lines
sbin/
devd/
24 lines
80 lines
74 lines
353 lines
20 lines
108 lines
146 lines
18 lines
77 lines

Diff 47048

View Options

head/etc/Makefile

Loading...
View Options

head/etc/devd.conf

Loading...
View Options

head/etc/devd/Makefile

Loading...
View Options

head/etc/devd/apple.conf

Loading...
View Options

head/etc/devd/asus.conf

Loading...
View Options

head/etc/devd/devmatch.conf

Loading...
View Options

head/etc/devd/hyperv.conf

Loading...
View Options

head/etc/devd/uath.conf

Loading...
View Options

head/etc/devd/ulpt.conf

Loading...
View Options

head/etc/devd/zfs.conf

Loading...
View Options

head/sbin/devd/Makefile

Loading...
View Options

head/sbin/devd/apple.conf

Loading...
View Options

head/sbin/devd/asus.conf

Loading...
View Options

head/sbin/devd/devd.conf

Loading...
View Options

head/sbin/devd/devmatch.conf

Loading...
View Options

head/sbin/devd/hyperv.conf

Loading...
View Options

head/sbin/devd/uath.conf

Loading...
View Options

head/sbin/devd/ulpt.conf

Loading...
View Options

head/sbin/devd/zfs.conf

Loading...