Paths

Table of Contentst

Differential D16485

Fix some TCP fast open issues
ClosedPublic
Actions

Authored by tuexen on Jul 28 2018, 4:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 2:34 AM

	Unknown Object (File)
	Nov 29 2024, 5:27 PM

	Unknown Object (File)
	Nov 18 2024, 3:34 AM

	Unknown Object (File)
	Nov 18 2024, 3:20 AM

	Unknown Object (File)
	Nov 18 2024, 3:02 AM

	Unknown Object (File)
	Nov 18 2024, 2:31 AM

	Unknown Object (File)
	Nov 18 2024, 2:12 AM

	Unknown Object (File)
	Nov 18 2024, 12:40 AM

View All 64 Files

Subscribers

Details

Reviewers

pkelsey
rrs
jtl
kbowling

Group Reviewers

Commits

rS336934: Fix some TCP fast open issues.

Summary

Whenever a TCP server with TCP fast open enabled, calls recv, send, and close before the TCP-ACK segment has been received, the TCP connection is just dropped and the reception of the TCP-ACK segment triggers the sending of a TCP RST segment.

Whenever a TCP server with TCP fast open enabled, calls recv, send, send, and close before the TCP-ACK segment has been received, the first byte provided in the second send call is not transferred.

Whenever a TCP client with TCP fast open enabled calls sendto followed by close the TCP connection was just dropped.

The second problem shows up when using thttpd with fast open enabled and requesting a CGI script.

This patch fixes the above issues.

Test Plan

Run the attached packetdrill scripts. They should pass and all fail without this patch.

passive-connection-setup-using-fo-two-sends-ipv4.pkt2 KBDownload

passive-connection-setup-using-fo-ipv4.pkt2 KBDownload

active-connection-setup-using-fo-ipv4.pkt3 KBDownload

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Jul 28 2018, 4:35 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 28 2018, 4:35 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B18396: Diff 45955.Jul 28 2018, 4:35 PM

jtl accepted this revision.Jul 28 2018, 11:28 PM

jtl added a subscriber: jtl.

jtl added inline comments.

sys/netinet/tcp_output.c
231 ↗	(On Diff #45955)	It looks like the comment is now stale.

This revision is now accepted and ready to land.Jul 28 2018, 11:28 PM

Update the comments as suggested by jtl@.

This revision now requires review to proceed.Jul 29 2018, 7:05 AM

Harbormaster completed remote builds in B18410: Diff 45981.Jul 29 2018, 7:05 AM

tuexen added inline comments.Jul 29 2018, 7:05 AM

sys/netinet/tcp_output.c
231 ↗	(On Diff #45955)	You are correct. I updated the comments.

kbowling accepted this revision.Jul 29 2018, 8:52 AM

This revision is now accepted and ready to land.Jul 29 2018, 8:52 AM

rrs accepted this revision.Jul 30 2018, 10:13 AM

Closed by commit rS336934: Fix some TCP fast open issues. (authored by tuexen). · Explain WhyJul 30 2018, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

20 lines

12 lines

3 lines

Diff 46045

head/sys/netinet/tcp_input.c

Loading...

head/sys/netinet/tcp_output.c

Loading...

head/sys/netinet/tcp_usrreq.c

Loading...