Simplify arm64's pmap_mincore().
ClosedPublic
Actions

Authored by markj on Jul 24 2018, 5:47 PM.

Details

Reviewers

manu
alc
andrew

Commits

rS336714: Simplify the arm64 implementation of pmap_mincore().

Summary

I wrote a pmap_mincore() for riscv and in the process noticed that
the arm64 implementation contained a lot of duplicated code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 24 2018, 5:47 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 24 2018, 5:47 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B18305: Diff 45792.Jul 24 2018, 5:47 PM

markj edited the summary of this revision. (Show Details)Jul 24 2018, 5:48 PM

markj added reviewers: alc, andrew.

alc accepted this revision.Jul 25 2018, 4:54 AM

This revision is now accepted and ready to land.Jul 25 2018, 4:54 AM

Is anyone working on "real" dirty bit maintenance for this pmap?

Closed by commit rS336714: Simplify the arm64 implementation of pmap_mincore(). (authored by markj). · Explain WhyJul 25 2018, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJul 25 2018, 3:58 PM

In D16427#348875, @alc wrote:

Is anyone working on "real" dirty bit maintenance for this pmap?

I don't know of any plans to work on that, FWIW.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

pmap.c

87 lines

Diff 45829

View Options

head/sys/arm64/arm64/pmap.c

Simplify arm64's pmap_mincore().ClosedPublicActions