audit(4): Syscalls concerned with modifying file 'flags'
ClosedPublic
Actions

Authored by aniketp on Jun 16 2018, 5:14 PM.

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335275: audit(4): add tests for chflags and friends

Summary

This revision introduces auditability tests for 3 syscalls within file-attribute-modify
audit class.
The system calls are:

chflags(2)
lchflags(2)
fchflags(2)

Test Plan

Execute make install from usr.sbin/praudit/tests.
Execute kyua test from /usr/test/usr.sbin/praudit. The test case should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17360
Build 17193: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 16 2018, 5:14 PM

Harbormaster completed remote builds in B17350: Diff 43909.Jun 16 2018, 5:14 PM

Add auclass in lchflags(2) test cases

Harbormaster completed remote builds in B17351: Diff 43910.Jun 16 2018, 5:16 PM

What about chflagsat ?

tests/sys/audit/file-attribute-modify.c
565	Setting this flag will cause cleanup to fail, if the securelevel > 0. Can you pick another flag? How about one that has no special meaning, like `UF_OFFLINE`?

This revision now requires changes to proceed.Jun 16 2018, 6:48 PM

Use UF_OFFLINE instead of SF_IMMUTABLE for easy cleanup

Harbormaster completed remote builds in B17360: Diff 43925.Jun 16 2018, 11:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 17 2018, 3:10 AM

Closed by commit rS335275: audit(4): add tests for chflags and friends (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 17 2018, 3:10 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

audit/

file-attribute-modify.c

142 lines

Diff 43925

View Options

tests/sys/audit/file-attribute-modify.c

audit(4): Syscalls concerned with modifying file 'flags'ClosedPublicActions