Page MenuHomeFreeBSD

Remove obsolete asf(8)
ClosedPublic

Authored by emaste on Jun 15 2018, 4:57 PM.

Details

Reviewers
jhb
brooks
Group Reviewers
manpages
Commits
rS335222: Remove obsolete asf(8)
Summary

kgdb now handles kernel module state internally, so the asf tool serves no purpose.

PR:             229046
Relnotes:       yes
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Jun 15 2018, 4:57 PM
emaste added a subscriber: rgrimes.

Does it make since to first commit a deprecation notice to this, which can be merged to stable/11, then actually remove it from ^/head after that? This avoids the need for a direct commit to stable/11

brooks accepted this revision.Jun 15 2018, 5:26 PM

LGTM. Doing the deprecation notice in the manpage seems like a good idea, but won't effect this review.

This revision is now accepted and ready to land.Jun 15 2018, 5:26 PM

@brooks a fully sgree, infact it can be done in a seperate review, and the asf binary should spit out a warning, not just a man page change.

perhaps this for deprecation notice:

Index: usr.sbin/asf/asf.8
===================================================================
--- usr.sbin/asf/asf.8  (revision 335216)
+++ usr.sbin/asf/asf.8  (working copy)
@@ -37,6 +37,15 @@
 .Op Fl o Ar outfile
 .Op Fl X Ar suffix
 .Op Ar modules-path Op Ar outfile
+.Sh DEPRECATION NOTICE
+The
+.Nm
+utility is not present in
+.Fx 12.0
+and later.
+The
+.Xr kgdb 1
+debugger handles kernel module state internally.
 .Sh DESCRIPTION
 By default,
 .Nm

I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.

This revision was automatically updated to reflect the committed changes.

I actually worry less about man page DEPRECATION, and more about having the binary spit something out so anyone using it for who knows what gets a heads up that it is/may be going away soon.

It hasn't served a purpose since 7.x so I went ahead with just the man page note.

jhb added a comment.Jun 15 2018, 5:50 PM

Spitting out a warning is less useful since the output generates a GDB script (though stderr would perhaps be ok). That said, this probably hasn't actually worked in several years and has rotted since kgdb grew native module support back in 7.1 release. I'm surprised it was x86 only. That seems a bit odd as there was nothing about this tool that was MD. All the arch-specific bits live in the objdump binary it invoked.