Page MenuHomeFreeBSD
Differential D15574

cpucontrol: fix debugging for family on AMD cpus and add useful debugging.
ClosedPublic
Actions

Authored by sbruno on May 25 2018, 5:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 11, 10:30 AM
Unknown Object (File)
Tue, Aug 11, 3:39 AM
Unknown Object (File)
Sat, Aug 8, 9:04 PM
Unknown Object (File)
Sat, Aug 8, 6:30 PM
Unknown Object (File)
Fri, Aug 7, 2:57 PM
Unknown Object (File)
Fri, Aug 7, 4:10 AM
Unknown Object (File)
Wed, Aug 5, 2:30 AM
Unknown Object (File)
Tue, Aug 4, 7:17 AM
View All Files
Subscribers
imp

Details

Reviewers
cem
emaste
markj
avg
Commits
rS335010: cpucontrol:
Summary

I noted that the display of family wasn't displaying correctly for AMD cpus

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbruno created this revision.May 25 2018, 5:17 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2018, 5:17 PM
Harbormaster completed remote builds in B16843: Diff 43000.May 25 2018, 5:17 PM
sbruno added a child revision: D15523: sysutils/devcpu-data: Update AMD microcode..May 25 2018, 5:18 PM
markj added a reviewer: avg.May 25 2018, 5:18 PM
cem accepted this revision.May 25 2018, 5:26 PM

LGTM modulo my first comment.

usr.sbin/cpucontrol/amd10h.c
142 ↗(On Diff #43000)

IIRC, extfamily bits are valid IFF family == 0xF. Which is handled by the macro in sys/. Would it be possible to just include the <machine/specialreg.h> and use the CPUID_TO_FAMILY() macro?

If we're merging the family and extfamily fields, we probably don't need to print extfamily too.

151 ↗(On Diff #43000)

Thanks!

This revision is now accepted and ready to land.May 25 2018, 5:26 PM
sbruno marked an inline comment as done.May 25 2018, 6:02 PM
sbruno added inline comments.
usr.sbin/cpucontrol/amd10h.c
142 ↗(On Diff #43000)

We already include <machine/specialreg.h> So this should be converted! let me take a stab at it.

I don't think we're merging the family/extfamily fields here. Are we? I'm not looking at the AMD SDM btw, just noted that the family was being displayed "wrong".

markj mentioned this in D15523: sysutils/devcpu-data: Update AMD microcode..May 25 2018, 7:57 PM
cem added inline comments.May 29 2018, 1:44 AM
usr.sbin/cpucontrol/amd10h.c
142 ↗(On Diff #43000)

Yep, this change is merging the family and extfamily fields — which is good, it’s closer to what users expect. Eg 17h is encoded as family=F + extfamily=something. Check CPUID_TO_FAMILY() for similarity with the shifts and masks printed here.

Closed by commit rS335010: cpucontrol: (authored by sbruno). · Explain WhyJun 12 2018, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
cpucontrol/
18 lines

Diff 43664

View Options

head/usr.sbin/cpucontrol/amd10h.c

Loading...