Page MenuHomeFreeBSD

Fix a race in vm_page_pagequeue_lockptr().
ClosedPublic

Authored by markj on May 17 2018, 4:11 AM.
Tags
None
Referenced Files
F83727020: D15462.id42656.diff
Tue, May 14, 1:56 AM
F83688755: D15462.id42657.diff
Mon, May 13, 4:23 PM
F83688721: D15462.id.diff
Mon, May 13, 4:22 PM
F83687585: D15462.diff
Mon, May 13, 4:01 PM
Unknown Object (File)
Fri, Apr 26, 11:54 AM
Unknown Object (File)
Jan 24 2024, 9:30 PM
Unknown Object (File)
Dec 23 2023, 6:35 AM
Unknown Object (File)
Dec 3 2023, 7:44 AM
Subscribers

Details

Summary

We check for m->queue == PQ_NONE but later use m->queue as an index. In
between the two references, the value of m->queue may change to PQ_NONE.
(The locking protocol ensures that m->queue cannot transition between
two queue indices: either the from-value or the to-value must be
PQ_NONE.) Read the value of m->queue once to avoid this problem.

Test Plan

Gleb reported seeing panics as a result of the use of a bogus
index into the pagequeue array, and also reported that this patch
fixed the panics.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added reviewers: kib, alc, jeff.
markj added a subscriber: glebius.
This revision is now accepted and ready to land.May 17 2018, 4:15 AM
This revision was automatically updated to reflect the committed changes.