Page MenuHomeFreeBSD

Fix a race in vm_page_pagequeue_lockptr().
ClosedPublic

Authored by markj on May 17 2018, 4:11 AM.
Tags
None
Referenced Files
F153205182: D15462.id42656.diff
Sun, Apr 19, 7:24 PM
F153097658: D15462.id42656.diff
Sun, Apr 19, 3:19 AM
Unknown Object (File)
Fri, Apr 17, 12:16 AM
Unknown Object (File)
Thu, Apr 16, 7:31 PM
Unknown Object (File)
Thu, Apr 16, 12:55 PM
Unknown Object (File)
Tue, Apr 14, 7:48 PM
Unknown Object (File)
Mon, Apr 13, 3:43 PM
Unknown Object (File)
Mon, Apr 13, 6:38 AM
Subscribers

Details

Summary

We check for m->queue == PQ_NONE but later use m->queue as an index. In
between the two references, the value of m->queue may change to PQ_NONE.
(The locking protocol ensures that m->queue cannot transition between
two queue indices: either the from-value or the to-value must be
PQ_NONE.) Read the value of m->queue once to avoid this problem.

Test Plan

Gleb reported seeing panics as a result of the use of a bogus
index into the pagequeue array, and also reported that this patch
fixed the panics.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added reviewers: kib, alc, jeff.
markj added a subscriber: glebius.
This revision is now accepted and ready to land.May 17 2018, 4:15 AM
This revision was automatically updated to reflect the committed changes.