Page MenuHomeFreeBSD

Fix a race in vm_page_pagequeue_lockptr().
ClosedPublic

Authored by markj on May 17 2018, 4:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 3, 5:20 AM
Unknown Object (File)
Wed, Sep 2, 6:08 PM
Unknown Object (File)
Wed, Sep 2, 3:46 PM
Unknown Object (File)
Wed, Sep 2, 1:04 PM
Unknown Object (File)
Wed, Sep 2, 9:28 AM
Unknown Object (File)
Tue, Sep 1, 4:08 AM
Unknown Object (File)
Mon, Aug 31, 1:05 PM
Unknown Object (File)
Sun, Aug 30, 11:44 AM
Subscribers

Details

Summary

We check for m->queue == PQ_NONE but later use m->queue as an index. In
between the two references, the value of m->queue may change to PQ_NONE.
(The locking protocol ensures that m->queue cannot transition between
two queue indices: either the from-value or the to-value must be
PQ_NONE.) Read the value of m->queue once to avoid this problem.

Test Plan

Gleb reported seeing panics as a result of the use of a bogus
index into the pagequeue array, and also reported that this patch
fixed the panics.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added reviewers: kib, alc, jeff.
markj added a subscriber: glebius.
This revision is now accepted and ready to land.May 17 2018, 4:15 AM
This revision was automatically updated to reflect the committed changes.