Check that ifma_protospec != NULL in inm_lookup
ClosedPublic
Actions

Authored by shurd on May 15 2018, 2:14 AM.

Tags

None

Referenced Files

	F83079270: D15440.diff
	Sun, May 5, 11:56 PM

	Unknown Object (File)
	Tue, Apr 30, 10:46 PM

	Unknown Object (File)
	Tue, Apr 30, 10:38 PM

	Unknown Object (File)
	Tue, Apr 30, 10:13 PM

	Unknown Object (File)
	Tue, Apr 30, 8:05 PM

	Unknown Object (File)
	Sep 23 2023, 11:02 AM

	Unknown Object (File)
	Sep 7 2023, 10:20 AM

	Unknown Object (File)
	Sep 7 2023, 10:19 AM

View All 18 Files

Subscribers

imp

kbowling

Details

Reviewers

dumbbell
mmacy
sbruno

Commits

rS333637: Check that ifma_protospec != NULL in inm_lookup

Summary

If ifma_protospec is NULL when inm_lookup() is called, there
is a dereference in a NULL struct pointer. This ensures that struct is
not NULL before comparing the address.

Test Plan

Have reporter test to ensure crash is fixed, beat on IGMP and
ensure the panic cannot be reproduced.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16594
Build 16506: arc lint + arc unit

Event Timeline

shurd created this revision.May 15 2018, 2:14 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 15 2018, 2:14 AM

Harbormaster completed remote builds in B16594: Diff 42559.May 15 2018, 2:14 AM

kbowling added a subscriber: kbowling.May 15 2018, 11:04 AM

sbruno accepted this revision.May 15 2018, 1:55 PM

This revision is now accepted and ready to land.May 15 2018, 1:55 PM

Closed by commit rS333637: Check that ifma_protospec != NULL in inm_lookup (authored by shurd). · Explain WhyMay 15 2018, 4:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_mcast.c

13 lines

Diff 42559

View Options

Check that ifma_protospec != NULL in inm_lookupClosedPublicActions