Check that ifma_protospec != NULL in inm_lookup
ClosedPublic
Actions

Authored by shurd on May 15 2018, 2:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 19, 11:14 PM

	Unknown Object (File)
	Thu, Jan 9, 5:07 PM

	Unknown Object (File)
	Dec 4 2024, 9:10 PM

	Unknown Object (File)
	Nov 7 2024, 6:11 PM

	Unknown Object (File)
	Oct 5 2024, 5:58 AM

	Unknown Object (File)
	Sep 29 2024, 9:20 PM

	Unknown Object (File)
	Sep 29 2024, 1:12 PM

	Unknown Object (File)
	Sep 28 2024, 2:28 PM

View All 38 Files

Subscribers

imp

kbowling

Details

Reviewers

dumbbell
mmacy
sbruno

Commits

rS333637: Check that ifma_protospec != NULL in inm_lookup

Summary

If ifma_protospec is NULL when inm_lookup() is called, there
is a dereference in a NULL struct pointer. This ensures that struct is
not NULL before comparing the address.

Test Plan

Have reporter test to ensure crash is fixed, beat on IGMP and
ensure the panic cannot be reproduced.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shurd created this revision.May 15 2018, 2:14 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 15 2018, 2:14 AM

Harbormaster completed remote builds in B16594: Diff 42559.May 15 2018, 2:14 AM

kbowling added a subscriber: kbowling.May 15 2018, 11:04 AM

sbruno accepted this revision.May 15 2018, 1:55 PM

This revision is now accepted and ready to land.May 15 2018, 1:55 PM

Closed by commit rS333637: Check that ifma_protospec != NULL in inm_lookup (authored by shurd). · Explain WhyMay 15 2018, 4:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

in_mcast.c

13 lines

Diff 42584

View Options

head/sys/netinet/in_mcast.c

Check that ifma_protospec != NULL in inm_lookupClosedPublicActions